Fix React combobox debounce #4331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertJoonas
force-pushed
the
react-combobox-debounce
branch
2 times, most recently
from
6568150
to
7d91706
Compare
|
ukutaht
reviewed
Jul 10, 2024
macobo
reviewed
Jul 10, 2024
macobo
reviewed
Jul 10, 2024
| if (isOpen) { | ||
| fetchOptions() | ||
| } | ||
| }, [search], 200) |
There was a problem hiding this comment.
Why is this 200 in one case and 300 in another?
Proposal: Let's unify and make it a exported const somewhere.
There was a problem hiding this comment.
Good point, agreed. The 'standard' delay could even be baked in to theuseDebouncedEffect and not be configurable.
RobertJoonas
force-pushed
the
react-combobox-debounce
branch
from
3a8db64
to
5a4152b
Compare
...And define the default delay in the hook
RobertJoonas
force-pushed
the
react-combobox-debounce
branch
from
9ee757c
to
7ff870b
Compare
|
Closed in favor of #4349 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In the
PlausibleComboboxcomponent (used in the filter menus and theprop_keypicker), we're currently making too many API calls to fetch selectable options. Currently, we're calling the API for every keystroke. This PR fixes that - we will only make a request once 200ms has passed from the last keystroke (reusing theuseDebouncedCallbackcustom hook introduced in #4318).Also in this PR:
useDebouncedEffectcustom hook to not set a delay for the initial function call. Currently the search in all breakdown modals is waiting 300ms before calling the API for the first time. This fixes that.Tests
Changelog
Documentation
Dark mode