Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return domain-less cookies in CE #4482

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

ruslandoga
Copy link
Contributor

@ruslandoga ruslandoga commented Aug 29, 2024

Changes

This PR removes domain option from cookies in CE making it possible to access dashboards from non-BASE_URL websites.

Tests

  • This PR does not need tests

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@ruslandoga ruslandoga added the self-hosting Anything self-hosted label Aug 29, 2024
@ruslandoga ruslandoga mentioned this pull request Aug 29, 2024
4 tasks
@ruslandoga ruslandoga force-pushed the domain-less-cookies-in-ce branch 2 times, most recently from 38f958c to 4a4e92c Compare August 29, 2024 11:25
@ruslandoga ruslandoga marked this pull request as ready for review August 29, 2024 11:27
@ruslandoga ruslandoga requested a review from a team August 29, 2024 11:33
@zoldar zoldar merged commit e7ac60c into master Sep 5, 2024
10 checks passed
@zoldar zoldar deleted the domain-less-cookies-in-ce branch September 5, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
self-hosting Anything self-hosted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants