-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to nginx reverse proxy for ws #119
Conversation
adding more reverse proxy settings to nginx proxy_set_header X-Forwarded-Ssl on; proxy_set_header Host $host
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@svandeneertwegh @ruslandoga Please review PR.
@@ -7,6 +7,8 @@ server { | |||
|
|||
location / { | |||
proxy_pass http://127.0.0.1:8000; | |||
proxy_set_header Host $host; | |||
proxy_set_header X-Forwarded-Ssl on; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think X-Forwarded-Ssl
would be used in Plausible in any way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use:
proxy_http_version 1.1;
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection "Upgrade";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, that was added in #113
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ruslandoga maybe you right and we don't need X-Forwarded-Ssl. Lets remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PS. Notice that PR is closed X-Forwarded-Ssl
would not do any bad, even if it works without it.
adding more reverse proxy settings to nginx
proxy_set_header X-Forwarded-Ssl on;
proxy_set_header Host $host