Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to nginx reverse proxy for ws #119

Closed
wants to merge 1 commit into from

Conversation

kurdin
Copy link

@kurdin kurdin commented Apr 25, 2024

adding more reverse proxy settings to nginx
proxy_set_header X-Forwarded-Ssl on;
proxy_set_header Host $host

adding more reverse proxy settings to nginx
                proxy_set_header X-Forwarded-Ssl on;
                proxy_set_header Host $host
Copy link
Author

@kurdin kurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svandeneertwegh @ruslandoga Please review PR.

@kurdin kurdin changed the title Update plausible Update to nginx reverse proxy for ws Apr 25, 2024
@ruslandoga ruslandoga deleted the branch plausible:allow-nginx-ws April 25, 2024 17:53
@ruslandoga ruslandoga closed this Apr 25, 2024
@@ -7,6 +7,8 @@ server {

location / {
proxy_pass http://127.0.0.1:8000;
proxy_set_header Host $host;
proxy_set_header X-Forwarded-Ssl on;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think X-Forwarded-Ssl would be used in Plausible in any way.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use:

proxy_http_version 1.1;
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection "Upgrade";

Copy link
Contributor

@ruslandoga ruslandoga Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, that was added in #113

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruslandoga maybe you right and we don't need X-Forwarded-Ssl. Lets remove it

Copy link
Author

@kurdin kurdin Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS. Notice that PR is closed X-Forwarded-Ssl would not do any bad, even if it works without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants