-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search tracking #87
Conversation
@jdevalk thanks for your work! Just thought about this half an hour ago and wanted to implement the manual way as we'll need it for a project :) |
Just merged my other pull for changing script paths into this one, if you only want the search change, just cherry-pick the first commit above. |
@Dan0sz could we also get this into the next version? crucial feature for us :) |
I'm game for anything @masteradhoc ;-) But it's really up to @metmarkosaric. |
this is one of the things we're looking to add for sure. i think proxy alone is worth one major release (and that's the priority for the next release) but let's see what else we can fit in there (or not too long after that) |
Meanwhile, @jdevalk, when you have time, would you mind fixing the merge conflicts? |
@Dan0sz So... I think the first commit in this pull is still the only thing you'd need, but it needs some support on the server side, I think? Let me open a new pull against the current code with just that in it. |
Replaced by #119 |
This adds tracking of search URLs, on sites with clean permalinks enabled they'd be tracked as
https://example.com/search/test/
.See my comment here though, I'm not so sure this is the right implementation.