Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search tracking #87

Closed
wants to merge 7 commits into from
Closed

Conversation

jdevalk
Copy link
Contributor

@jdevalk jdevalk commented Jul 19, 2022

This adds tracking of search URLs, on sites with clean permalinks enabled they'd be tracked as https://example.com/search/test/.

See my comment here though, I'm not so sure this is the right implementation.

@masteradhoc
Copy link

@jdevalk thanks for your work! Just thought about this half an hour ago and wanted to implement the manual way as we'll need it for a project :)

@jdevalk
Copy link
Contributor Author

jdevalk commented Jul 21, 2022

Just merged my other pull for changing script paths into this one, if you only want the search change, just cherry-pick the first commit above.

@masteradhoc
Copy link

@Dan0sz could we also get this into the next version? crucial feature for us :)

@Dan0sz
Copy link
Collaborator

Dan0sz commented Apr 5, 2023

I'm game for anything @masteradhoc ;-) But it's really up to @metmarkosaric.

@metmarkosaric
Copy link
Collaborator

this is one of the things we're looking to add for sure. i think proxy alone is worth one major release (and that's the priority for the next release) but let's see what else we can fit in there (or not too long after that)

@Dan0sz
Copy link
Collaborator

Dan0sz commented Apr 5, 2023

Meanwhile, @jdevalk, when you have time, would you mind fixing the merge conflicts?

@jdevalk
Copy link
Contributor Author

jdevalk commented Apr 13, 2023

@Dan0sz So... I think the first commit in this pull is still the only thing you'd need, but it needs some support on the server side, I think? Let me open a new pull against the current code with just that in it.

@jdevalk jdevalk closed this Apr 13, 2023
@jdevalk jdevalk deleted the jdv/track-search branch April 13, 2023 11:46
@jdevalk
Copy link
Contributor Author

jdevalk commented Apr 13, 2023

Replaced by #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants