don't rethrow reference and syntax errors #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ff(function () { | ||
| JSON.parse("oops"); | ||
| }).onComplete(f.slot()); |
There was a problem hiding this comment.
Change these to wait:
}).onComplete(f.wait());
There was a problem hiding this comment.
Why? They do the same thing in this case.
There was a problem hiding this comment.
It's more semantically correct. You are not doing anything with the parameters of the callback, so slot is inappropriate. See my comment below for how to use slot to make sure we are getting all the expected errors.
|
I like this change Teddy, fix the test and we should be good to go. If you really want to be a rock star, attach onError handlers instead to each sub-test and then slotPlain the error to the final completion handler. Then assert to make sure you get the error types you expect (ie string, error, reference error, syntax error). |
|
coolio, done! |
mikehenrty
added a commit
that referenced
this pull request
Sep 26, 2013
don't rethrow reference and syntax errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice for catching human errors, but ends up not catching stuff like JSON.parse() errors. Better to trust the human to code well...or use a linter :)
(Worst case, human errors will either get rethrown or always trigger the error handler anyway.)