Cleaned up material references in render component # onRemove #4126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mvaligursky - since you own the |
mvaligursky
approved these changes
Mar 18, 2022
mvaligursky
approved these changes
Mar 18, 2022
|
Request re-review please @mvaligursky The EntityReference doesn't need to be manually cleaned up as it listens for the remove event on the component and cleans itself up. This does mean we have an inconsistency between EntityReference and AssetReference where one needs to be cleanup when the owner is destroy and the other manages itself. |
mvaligursky
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4124
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.