Add retry option for glue and fallback downloading methods

[zishiwu123]

Fixes #4078

Adds maxRetries. Consistent with: https://github.com/playcanvas/engine/blob/main/src/resources/scene-utils.js#L14.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

[willeastcott]

What about this line:

engine/src/resources/basis.js

Line 302 in 5c48117

prepareWorkerModules(config, (err, clientConfig) => {

[zishiwu123]

What about this line:

engine/src/resources/basis.js

Line 302 in 5c48117

prepareWorkerModules(config, (err, clientConfig) => {

Good point. However the basisInitialize() function that calls prepareWorkerModules() currently does not have a maxRetries parameter. We could create a maxRetries parameter with a default value in basisInitialize() like this example:

engine/src/resources/loader.js

Line 277 in 5c48117

enableRetry(maxRetries = 5) {

But I'm not sure if:

• a) that's the right way to go?
• b) what the default value would be?

[willeastcott]

Possibly. @slimbuck - what do you think?

[willeastcott]

I'd suggest making maxRetries a property of the config object passed into basisInitialize (defaulting to 5 maybe?). But yeah, I'll leave it to @slimbuck to provide some thoughts...

[slimbuck]

I'd suggest making maxRetries a property of the config object passed into basisInitialize (defaulting to 5 maybe?). But yeah, I'll leave it to @slimbuck to provide some thoughts...

I agree. We want maxRetries added to the basis config. In prepareWorkerModules, if maxRetries is missing, default to 5.

[slimbuck]

Thanks for this @zishiwu123 it's awesome!

[zishiwu123]

@slimbuck Good catch pointing out that config.maxRetries = 0 is a valid value but the expression (config.maxRetries || defaultMaxRetries) would have evaluated to false and used defaultMaxRetries when it shouldn't have. You should be included as a co-author in this PR.

[slimbuck]

🥳 nice one!

[willeastcott]

Seconded. 😄 Thanks for the contribution @zishiwu123!