Organize shader chunks #4151
Merged
Organize shader chunks #4151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 24, 2022 10:14
willeastcott
approved these changes
Mar 24, 2022
mvaligursky
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR organises shader chunks into subfolders in order to prepare for upcoming engine material changes.
The chunks are categorised as follows:
chunks- shared and one-off chunkschunks/lightmapper- chunks specific to the lightmapperchunks/lit- lighting "backend" chunks. These will be exposed in future as a newLitMaterialmaterial.chunks/particle- particle system-specific chunkschunks/skybox- skybox material chunkschunks/standard- the standard material "front-end" chunksThis PR is only the first step toward updating our material system and as such doesn't change API, but please note that in future:
chunks/standardand will endeavour to change these chunks as little as possible.chunks/litand users should not rely on the stability of these.In addition the following two chunks have been removed: