Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anim tests #4158

Merged
merged 4 commits into from
Apr 4, 2022
Merged

Anim tests #4158

merged 4 commits into from
Apr 4, 2022

Conversation

ellthompson
Copy link
Contributor

@ellthompson ellthompson commented Mar 31, 2022 •
edited
Loading

Adds mocha tests which cover the src/anim/controller and src/anim/evaluator and src/anim/state-graph directories.

Fixes #3933

Also fixes three issues in the anim directory:

  • Fixed a divide by 0 bug in AnimBlendTreeDirect
  • The docs for the AnimNode's point parameter has been fixed
  • Calling updateValue on an AnimTargetValue instance that doesn't have a setter method no longer throws an exception

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@ellthompson ellthompson added the area: animation Animation related issue label Mar 31, 2022
@ellthompson ellthompson self-assigned this Mar 31, 2022
willeastcott
willeastcott approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with some comments.

@ellthompson ellthompson marked this pull request as ready for review April 4, 2022 14:01
@ellthompson ellthompson merged commit 4e13e5b into main Apr 4, 2022
@ellthompson ellthompson deleted the anim-tests branch April 4, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck left review comments

@willeastcott willeastcott willeastcott approved these changes

Assignees

@ellthompson ellthompson

Labels
area: animation Animation related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Engine anim directory unit tests
3 participants
@ellthompson @willeastcott @slimbuck