Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate more unit tests from Karma to Node #4163

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Conversation

willeastcott
Copy link
Contributor

@willeastcott willeastcott commented Apr 2, 2022

This PR migrates more unit tests from Karma (tests) to Node (test):

  • BatchManager
  • Http
  • I18n
  • ModelComponent

Current number of tests:

  • 890 in Node
  • 324 in Karma

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@willeastcott willeastcott requested a review from a team April 2, 2022 13:37
@willeastcott willeastcott self-assigned this Apr 2, 2022
Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@willeastcott willeastcott merged commit 3156030 into main Apr 4, 2022
@willeastcott willeastcott deleted the more-node-tests branch April 4, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants