Update substr calls to substring
#4276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeastcott
changed the title
substr calls to substring
kungfooman
reviewed
May 29, 2022
Comment on lines
+26
to
+28
| defineProtoFunc(String, 'startsWith', function(search, rawPos) { | ||
| var pos = rawPos > 0 ? rawPos|0 : 0; | ||
| return this.substring(pos, pos + search.length) === search; |
There was a problem hiding this comment.
Suggested change
| defineProtoFunc(String, 'startsWith', function(search, rawPos) { | |
| var pos = rawPos > 0 ? rawPos|0 : 0; | |
| return this.substring(pos, pos + search.length) === search; | |
| defineProtoFunc(String, 'startsWith', function(search, pos) { | |
| pos = pos > 0 ? pos|0 : 0; | |
| return this.substring(pos, pos + search.length) === search; |
(removing var while reusing pos variable)
There was a problem hiding this comment.
I know this code can be tweaked but I'm just updating what's here to the linked Polyfill on MDN. I'd rather keep this in sync with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4252
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.