Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Grab pass (color, depth) now properly support multiple cameras #4340

Merged
merged 1 commit into from
Jun 17, 2022
Merged

[Fix] Grab pass (color, depth) now properly support multiple cameras #4340

merged 1 commit into from
Jun 17, 2022

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jun 17, 2022 •
edited
Loading

  • before, the uniforms values were only set when the render target was created. Which means that if multiple cameras were grabbing depth or color buffer, only last texture would be used for rendering.
  • now the value gets assigned each frame, as the buffers are grabbed.

@mvaligursky mvaligursky self-assigned this Jun 17, 2022
@mvaligursky mvaligursky added bug area: graphics Graphics related issue labels Jun 17, 2022
@mvaligursky mvaligursky merged commit e3e6c73 into main Jun 17, 2022
@mvaligursky mvaligursky deleted the mvaligursky-scenegrab-multicam branch June 17, 2022 09:40
@snyk-bot snyk-bot mentioned this pull request Jun 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

@GSterbrant GSterbrant Awaiting requested review from GSterbrant

@willeastcott willeastcott Awaiting requested review from willeastcott

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @slimbuck