Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix to sharing of clustered light buffer between layers #4362

Merged
merged 1 commit into from
Jun 23, 2022
Merged

[Fix] Fix to sharing of clustered light buffer between layers #4362

merged 1 commit into from
Jun 23, 2022

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jun 22, 2022 •
edited
Loading

  • sharing with an empty clusters is avoided
  • disable whitespaces in dif
  • fixes clustered lighting working with Layers.tsx, as its first sub-layer had no meshes, and empty clusters from it were shared.

@mvaligursky mvaligursky self-assigned this Jun 22, 2022
@mvaligursky mvaligursky added bug area: graphics Graphics related issue labels Jun 22, 2022
@mvaligursky mvaligursky merged commit d7884b0 into main Jun 23, 2022
@mvaligursky mvaligursky deleted the mvaligursky-clusters-sharing-fix branch June 23, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

@GSterbrant GSterbrant Awaiting requested review from GSterbrant

@slimbuck slimbuck Awaiting requested review from slimbuck

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @willeastcott