Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] Enable clustered lighting by default #4364

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jun 23, 2022

Until now, the clustered lighting was a feature the user had to opt in.
This PR makes it the default option, and the original lighting system is opt in.

If the original system needs to be used, this is the API to call:

            app.scene.clusteredLightingEnabled = false;

Note that by default, the area lights and cookie textures are disabled for clustered lighting (in order to keep the shader smaller / faster to compile), and can be enabled this way if needed:

            app.scene.lighting.cookiesEnabled = true;
            app.scene.lighting.areaLightsEnabled = true;

@mvaligursky mvaligursky changed the title Enable clustered lighting by default [Breaking] Enable clustered lighting by default Jun 23, 2022
@mvaligursky mvaligursky self-assigned this Jun 23, 2022
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Jun 23, 2022
@mvaligursky mvaligursky merged commit 27da510 into main Jun 29, 2022
@mvaligursky mvaligursky deleted the mvaligursky-clustered-default branch June 29, 2022 09:25
mvaligursky added a commit that referenced this pull request Aug 1, 2022
Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
slimbuck pushed a commit that referenced this pull request Aug 1, 2022
Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants