Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle scenes with skybox #4403

Merged
merged 3 commits into from
Jul 6, 2022
Merged

Handle scenes with skybox #4403

merged 3 commits into from
Jul 6, 2022

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented Jul 5, 2022

Object reflections were being ignored if the scene cubemap didn't have prefiltered lighting data.

This scene has a cubemap without prefiltering and a simple material with refraction enabled.

Before:
Screenshot 2022-07-05 at 18 42 34

After:
Screenshot 2022-07-05 at 18 42 36

@slimbuck slimbuck added bug area: graphics Graphics related issue labels Jul 5, 2022
@slimbuck slimbuck requested a review from a team July 5, 2022 17:46
@slimbuck slimbuck self-assigned this Jul 5, 2022
@slimbuck slimbuck merged commit a0c2f0e into playcanvas:main Jul 6, 2022
@slimbuck slimbuck deleted the scene-env-fix branch July 6, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants