Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OffscreenCanvas in Web Workers #5168

Conversation

michaelfranzl
Copy link
Contributor

@michaelfranzl michaelfranzl commented Mar 19, 2023

Fixes #2481

This probably needs the development of a minimal example (and perhaps automatic tests). Since this is my first contribution, please advise on how to proceed.

I'm happy to discuss and improve the implementation if needed.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@willeastcott willeastcott added feature request area: graphics Graphics related issue release: next minor Ticket marked for the next minor release labels Mar 19, 2023
src/core/platform.js Outdated Show resolved Hide resolved
src/core/platform.js Outdated Show resolved Hide resolved
@GSterbrant GSterbrant added the open source contribution Issues related to contributions from people outside the PlayCanvas team label May 12, 2023
@mvaligursky mvaligursky removed the release: next minor Ticket marked for the next minor release label Nov 6, 2023
@michaelfranzl michaelfranzl force-pushed the 2481_support_for_web_workers_20230319 branch from c185bf4 to 957af98 Compare July 14, 2024 16:25
@michaelfranzl michaelfranzl force-pushed the 2481_support_for_web_workers_20230319 branch from 957af98 to 6c11340 Compare July 14, 2024 16:27
@michaelfranzl michaelfranzl force-pushed the 2481_support_for_web_workers_20230319 branch from 6c11340 to 3892fc6 Compare July 14, 2024 16:40
src/core/platform.js Outdated Show resolved Hide resolved
@willeastcott willeastcott merged commit 0d3f424 into playcanvas:main Jul 15, 2024
8 checks passed
@willeastcott
Copy link
Contributor

Thanks for the contribution! I removed platform.worker from the public API though because it's uncomfortably close to platform.workers.

@willeastcott
Copy link
Contributor

I've also cherry-picked this to main_v1 so it will be included in the next minor release of 1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue feature request open source contribution Issues related to contributions from people outside the PlayCanvas team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate implementation of OffscreenCanvas API
5 participants