-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for OffscreenCanvas in Web Workers #5168
Merged
willeastcott
merged 3 commits into
playcanvas:main
from
michaelfranzl:2481_support_for_web_workers_20230319
Jul 15, 2024
Merged
Support for OffscreenCanvas in Web Workers #5168
willeastcott
merged 3 commits into
playcanvas:main
from
michaelfranzl:2481_support_for_web_workers_20230319
Jul 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeastcott
added
feature request
area: graphics
Graphics related issue
release: next minor
Ticket marked for the next minor release
labels
Mar 19, 2023
GSterbrant
added
the
open source contribution
Issues related to contributions from people outside the PlayCanvas team
label
May 12, 2023
mvaligursky
removed
the
release: next minor
Ticket marked for the next minor release
label
Nov 6, 2023
michaelfranzl
force-pushed
the
2481_support_for_web_workers_20230319
branch
from
July 14, 2024 16:25
c185bf4
to
957af98
Compare
michaelfranzl
force-pushed
the
2481_support_for_web_workers_20230319
branch
from
July 14, 2024 16:27
957af98
to
6c11340
Compare
michaelfranzl
force-pushed
the
2481_support_for_web_workers_20230319
branch
from
July 14, 2024 16:40
6c11340
to
3892fc6
Compare
michaelfranzl
force-pushed
the
2481_support_for_web_workers_20230319
branch
from
July 15, 2024 17:40
3892fc6
to
02610d3
Compare
willeastcott
approved these changes
Jul 15, 2024
Thanks for the contribution! I removed |
I've also cherry-picked this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: graphics
Graphics related issue
feature request
open source contribution
Issues related to contributions from people outside the PlayCanvas team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2481
This probably needs the development of a minimal example (and perhaps automatic tests). Since this is my first contribution, please advise on how to proceed.
I'm happy to discuss and improve the implementation if needed.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.