Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebXR Hands Example - AR/VR modes #6189

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

Maksims
Copy link
Contributor

@Maksims Maksims commented Mar 20, 2024

com.oculus.shellenv-20240320-122013.mp4

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@kpal81xd
Copy link
Contributor

Looks good the html and css file injection is something that needs to be changed - You shouldnt need to have to inject it yourself.

@kpal81xd kpal81xd self-assigned this Mar 20, 2024
@kpal81xd kpal81xd merged commit a7f0eef into playcanvas:main Mar 20, 2024
7 checks passed
@Maksims
Copy link
Contributor Author

Maksims commented Mar 20, 2024

Looks good the html and css file injection is something that needs to be changed - You shouldnt need to have to inject it yourself.

That would be great, I was looking at other examples, and haven't seen that pattern, so came up with that. If there would be a generic way to do it - that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants