Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GS rendering v2.0 #6357

Merged
merged 6 commits into from
May 15, 2024
Merged

Update GS rendering v2.0 #6357

merged 6 commits into from
May 15, 2024

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented May 13, 2024 •
edited
Loading

Having done more profiling, it seems that the order of splat data is by far the most important element when rendering large GS scenes on GPU.

Therefore this PR supersedes #6352: it takes the best parts, but without the additional memory requirements of the preprocess step.

Before:
Screenshot 2024-05-10 at 16 07 53

After:
Screenshot 2024-05-10 at 16 08 24

So, this PR:

  • Uploads splat order data to texture instead of uploading duplicate vertex data.
  • Renders splats by instancing a 128-quad mesh.
  • Refrains from rendering splats behind the camera.
  • Reorder uncompressed data at startup to match compressed format.
  • Default to half float for storing uncompressed data.

Issues:

  • reordering millions of splats at load time is not fast. For fast load time, use the compressed format. (We will investigate improving reorder performance in future)
  • we might want to expose a load-time option for users to disable splat reorder on load

Next steps:

  • Implement rendering directly from compressed format. This will cut runtime memory usage 4x.

@slimbuck slimbuck mentioned this pull request May 13, 2024
Closed
@slimbuck @willeastcott
Update src/scene/gsplat/gsplat-instance.js
0359543 
Co-authored-by: Will Eastcott <willeastcott@gmail.com>
@vercel Vercel
Copy link

vercel bot commented May 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
engine ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 9:52am

mvaligursky
mvaligursky reviewed May 15, 2024
View reviewed changes
src/scene/gsplat/gsplat-instance.js
// number of quads to combine into a single instance. this is to increase occupancy
// in the vertex shader.
const splatInstanceSize = 128;
const numSplats = Math.ceil(splat.numSplats / splatInstanceSize) * splatInstanceSize;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use math.roundUp

@slimbuck slimbuck merged commit 614aedb into playcanvas:main May 15, 2024
8 of 9 checks passed
@slimbuck slimbuck deleted the gs-take-two branch May 15, 2024 09:51
@slimbuck slimbuck mentioned this pull request May 15, 2024
Merged
slimbuck added a commit to slimbuck/engine that referenced this pull request May 20, 2024
@slimbuck
Update GS rendering v2.0 (playcanvas#6357)
374aa91
@willeastcott willeastcott mentioned this pull request May 30, 2024
Closed
@slimbuck slimbuck mentioned this pull request Jun 24, 2024
Closed
@slimbuck slimbuck mentioned this pull request Aug 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaligursky mvaligursky mvaligursky approved these changes

@willeastcott willeastcott willeastcott approved these changes

Assignees

@slimbuck slimbuck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slimbuck @willeastcott @mvaligursky