Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to layer handling by render passes #7001

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Oct 1, 2024

related to #6949

  • When a RenderPassCamera creates forward render passes, it includes even disabled layers, and the layers can be later toggled on and off as needed
  • When a layer from the composition is deleted, a warning is printed and the layer is ignored if still included in forward passes. Those need to be re-created to avoid this.
  • when PostEffects are used on the same camera as render passes, a warning is logged and post-effects are skipped, as this is not compatible

@mvaligursky mvaligursky merged commit e8aa2d6 into main Oct 1, 2024
8 checks passed
@mvaligursky mvaligursky deleted the mv-renderpass-forward-enabling branch October 1, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants