New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor `SliderInput` #236

Merged

willeastcott merged 1 commit into main from refactor-sliderinput

Jan 2, 2023

Contributor

willeastcott commented Jan 1, 2023

Eliminate uses of Object.defineProperty to programmatically add getters/setters to SliderInput. This prevents them from appearing in the docs or the types.
Remove the pre property of the SliderInput args object (there for backwards compatibility of precision). I don't see it used by any other projects.
Remove the utility proxy function which is no longer used.


          Refactor SliderInput

4bc5ab8

willeastcott added the enhancement label

willeastcott requested a review from a team

January 1, 2023 23:16

willeastcott self-assigned this

slimbuck approved these changes

View reviewed changes

willeastcott merged commit be1427c into main

willeastcott deleted the refactor-sliderinput branch

January 2, 2023 23:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels