Update CLI to Allow Compilation to any File Type #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
=======================================
Coverage 73.05% 73.05%
=======================================
Files 87 87
Lines 12946 12946
Branches 1216 1217 +1
=======================================
Hits 9458 9458
Misses 3469 3469
Partials 19 19 ☔ View full report in Codecov by Sentry. |
|
/canary |
1 similar comment
|
/canary |
|
/canary |
KetanReddy
changed the title
hborawski
approved these changes
Jul 19, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the CLI assumes that any result from the compilation hook is an object that can be serialized to JSON and should be written to a file that ends in
.js. There are potentially other usecases for compiling Player related content that may not result in a JSON serializable result. This PR expands the results to generalize what the compilation is to be some string that should be written as the output file, and an optional second string that should be written as the source map.Change Type (required)
Indicate the type of change your pull request is:
patchminormajorRelease Notes
Allow DSL compilation phase to compile to non
.jsontargets📦 Published PR as canary version:
0.7.0--canary.146.3413Try this version out locally by upgrading relevant packages to 0.7.0--canary.146.3413
Version
Published prerelease version:
0.7.0-next.7Changelog
Release Notes
Update CLI to Allow Compilation to any File Type (#146)
Allow DSL compilation phase to compile to non
.jsontargetsFix Issue Validating Templates (#125)
XLR - Fully resolve references, intersection types, conditional types, and generic types when returning a type
JSON Language Server - Add generic tokens when constructing template types in transform
Validation - Fix issue validating nested arrays in templates.
#132 - Adds a dev tools web plugin generator (#133)
Adds a generator to facilitate adding new dev tools web plugins:
Fix Bug when Validating
nullliterals (#123)Validator - Properly validate
NullTypenodes againstnullliteralsFix Parsing Indexed Access Types with Parentheses (#112)
XLR - Fixed compilation of
IndexedAccesNodesthat use parentheses around the first element.Fix Regression on Validation of Keys with Escaped Characters (#110)
XLR - Fixes validation of objects where a property is escaped using single/double quotes and the property is required or the object doesn't allow additional properties.
🚀 Enhancement
🐛 Bug Fix
nullliterals #123 (@KetanReddy)📝 Documentation
Authors: 7