Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP API Improvements #85

Merged
merged 1 commit into from
Mar 27, 2024
Merged

LSP API Improvements #85

merged 1 commit into from
Mar 27, 2024

Conversation

KetanReddy
Copy link
Member

@KetanReddy KetanReddy commented Mar 21, 2024

Cleaning up the ergonomics around the LSP API, specifically around CLI config usage.

Change Type (required)

  • patch
  • minor
  • major

Release Notes

  • Allow LSPAssetsPlugin to take multiple XLR bundles.
  • Allow LSPPluginPlugin to take multiple LSP plugins.
📦 Published PR as canary version: 0.5.2--canary.85.2217

Try this version out locally by upgrading relevant packages to 0.5.2--canary.85.2217

Version

Published prerelease version: 0.5.2-next.1

Changelog

Release Notes

LSP API Improvements (#85)

  • Allow LSPAssetsPlugin to take multiple XLR bundles.
  • Allow LSPPluginPlugin to take multiple LSP plugins.

Fix Import Errors When Using DSL in ESM First Projects (#87)

Fix issue with DSL package in ESM projects

Bazel 7 (#86)

Internal - Use Bazel 7 for builds.


🐛 Bug Fix

Authors: 3

@KetanReddy KetanReddy added the patch Increment the patch version when merged label Mar 21, 2024
@KetanReddy KetanReddy self-assigned this Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.34%. Comparing base (7ff4937) to head (ac5c654).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage   77.34%   77.34%           
=======================================
  Files          62       62           
  Lines       10425    10425           
  Branches     1085     1085           
=======================================
  Hits         8063     8063           
  Misses       2343     2343           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KetanReddy
Copy link
Member Author

/canary

@KetanReddy
Copy link
Member Author

/canary

@KetanReddy KetanReddy changed the title [WIP] LSP API Improvements LSP API Improvements Mar 26, 2024
@KetanReddy KetanReddy marked this pull request as ready for review March 26, 2024 18:41
@KetanReddy KetanReddy merged commit bc6140b into main Mar 27, 2024
9 checks passed
@KetanReddy KetanReddy deleted the feature/lsp-api-improvements branch March 27, 2024 18:47
@intuit-svc intuit-svc mentioned this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants