remove -J from -J-javaagent #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove -J from -J-javaagent that cause Unrecognized option: -J-javaagent
|
This depends on what sbt runner you're using. sbt-extras started it, and then sbt-launcher-package broke it. We need to find something cross-compatible... |
|
Aha. Thanks for comment. you are right I will find a way to detect the SBT version and change the option base on that. |
What do you mean by "broke it"? Asking because I was bitten by this too and |
|
The usage text also lies. |
octonato
pushed a commit
to octonato/play-samples
that referenced
this pull request
Dec 4, 2019
…ork#28) /.travis.yml: wrote /.travis.yml **/build.properties: sbt.version=1.2.8
octonato
pushed a commit
to octonato/play-samples
that referenced
this pull request
Dec 4, 2019
…o 2.6.x * play-java-compile-di-example/2.6.x: (44 commits) Nest play-java-compile-di-example Updated with template-control on 2019-02-13T20:25:39.247Z (playframework#53) Upgrade branch 2.6.x using TemplateControl (playframework#51) Updated with template-control on 2019-01-17T15:10:57.466Z /.mergify.yml: wrote /.mergify.yml Updated with template-control on 2019-01-16T12:08:45.201Z /LICENSE: wrote /LICENSE /NOTICE: wrote /NOTICE /.mergify.yml: wrote /.mergify.yml Upgrade branch 2.6.x using TemplateControl (playframework#47) Updated with template-control on 2019-01-04T17:13:23.849Z (playframework#42) Remove oraclejdk10 (EOLed) Updated with template-control on 2018-11-29T15:50:43.084Z /.mergify.yml: wrote /.mergify.yml **build.sbt: scalaVersion := "2.12.7" Updated with template-control on 2018-10-08T19:11:40.693Z **/plugins.sbt: addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20") **build.gradle: def playVersion = "2.6.20" Updated with template-control on 2018-09-11T20:14:49.826Z (playframework#37) Updated with template-control on 2018-08-20T20:37:13.525Z (playframework#36) Updated with template-control on 2018-07-19T01:58:55.323Z (playframework#34) Updated with template-control on 2018-07-16T18:38:44.960Z (playframework#33) Upgrade branch 2.6.x using TemplateControl (playframework#32) Updated with template-control on 2018-05-27T23:54:09.062Z (playframework#31) Updated with template-control on 2018-04-06T19:34:57.520Z (playframework#29) Updated with template-control on 2018-03-02T18:56:27.911Z (playframework#28) Upgrade branch 2.6.x using TemplateControl (playframework#27) Fix cross build to sbt 1.1.0 (playframework#26) ...
octonato
pushed a commit
to octonato/play-samples
that referenced
this pull request
Dec 4, 2019
* play-java-forms-example/2.6.x: (40 commits) Nest play-java-forms-example Updated with template-control on 2019-02-13T20:25:39.587Z (playframework#53) Upgrade branch 2.6.x using TemplateControl (playframework#51) Updated with template-control on 2019-01-17T15:10:57.484Z /.mergify.yml: wrote /.mergify.yml Updated with template-control on 2019-01-16T12:08:45.857Z /LICENSE: wrote /LICENSE /NOTICE: wrote /NOTICE /.mergify.yml: wrote /.mergify.yml Updated with template-control on 2019-01-08T14:44:41.293Z (playframework#47) Updated with template-control on 2019-01-04T17:13:23.788Z (playframework#42) Upgrade branch 2.6.x using TemplateControl (playframework#40) Updated with template-control on 2018-10-08T19:11:40.943Z **/plugins.sbt: addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20") **build.gradle: def playVersion = "2.6.20" Updated with template-control on 2018-09-11T20:14:49.983Z (playframework#36) Updated with template-control on 2018-08-20T20:37:13.462Z (playframework#35) Updated with template-control on 2018-07-19T01:58:55.809Z (playframework#33) Updated with template-control on 2018-07-16T18:38:45.455Z (playframework#32) Upgrade branch 2.6.x using TemplateControl (playframework#31) Updated with template-control on 2018-05-27T23:54:08.761Z (playframework#30) Updated with template-control on 2018-04-06T19:34:58.048Z (playframework#28) Updated with template-control on 2018-03-02T18:56:28.055Z (playframework#27) Upgrade branch 2.6.x using TemplateControl (playframework#26) Fix cross build to sbt 1.1.0 (playframework#25) Upgrade branch 2.6.x using TemplateControl (playframework#24) ...
octonato
pushed a commit
to octonato/play-samples
that referenced
this pull request
Dec 4, 2019
….6.x * play-scala-log4j2-example/2.6.x: (36 commits) Nest play-scala-log4j2-example Updated with template-control on 2019-02-13T20:25:39.787Z (playframework#39) Upgrade branch 2.6.x using TemplateControl (playframework#37) Updated with template-control on 2019-01-17T15:10:57.918Z /.mergify.yml: wrote /.mergify.yml Updated with template-control on 2019-01-16T12:08:45.730Z /LICENSE: wrote /LICENSE /NOTICE: wrote /NOTICE /.mergify.yml: wrote /.mergify.yml **build.gradle: playTest "org.scalatestplus.play:scalatestplus-play_$scalaVersion:3.1.2" Updated with template-control on 2019-01-08T14:44:41.516Z (playframework#33) Updated with template-control on 2019-01-04T17:13:24.081Z (playframework#28) Remove JDK 9 & 10 Updated with template-control on 2018-11-29T15:50:43.150Z /.mergify.yml: wrote /.mergify.yml Updated with template-control on 2018-10-08T19:11:41.210Z **/plugins.sbt: addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20") **build.gradle: def playVersion = "2.6.20" Updated with template-control on 2018-09-11T20:14:50.549Z (playframework#23) set log4j2.xml as javaOptions (playframework#20) Updated with template-control on 2018-08-20T20:37:13.971Z (playframework#22) Updated with template-control on 2018-07-19T01:58:55.708Z (playframework#19) Updated with template-control on 2018-07-16T18:38:45.739Z (playframework#18) Upgrade branch 2.6.x using TemplateControl (playframework#17) Updated with template-control on 2018-05-27T23:54:08.860Z (playframework#16) Updated with template-control on 2018-04-06T19:34:58.294Z (playframework#14) Updated with template-control on 2018-03-02T18:56:28.624Z (playframework#13) Upgrade branch 2.6.x using TemplateControl (playframework#12) ...
|
This should update the Scala example as well. Duplicate of https://github.com/playframework/play-samples/pull/92/files |
|
Closing this in favor of #92 |
|
#92 solves one case. This PR solves other cases. Both PRs are necessary |
|
should no longer be needed since #111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove -J from -J-javaagent that cause Unrecognized option: -J-javaagent