Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build gRPC samples with Scala 2.13 when upstream deps are ready for 2.13 #33

Closed
octonato opened this issue Jun 24, 2019 · 1 comment
Closed

Build gRPC samples with Scala 2.13 when upstream deps are ready for 2.13 #33

octonato opened this issue Jun 24, 2019 · 1 comment

Comments

@octonato
Copy link
Contributor

octonato commented Jun 24, 2019 •
edited
Loading

This is a spin-off from #32.

gRPC samples can't build with 2.13 for the moment.
@dwijnand dwijnand removed the triage label Jun 24, 2019
@dwijnand dwijnand mentioned this issue Jun 24, 2019
Closed
16 tasks
@octonato octonato mentioned this issue Jun 25, 2019
Merged
octonato added a commit to octonato/play-samples that referenced this issue Dec 4, 2019
@octonato @mergify
Updated with template-control on 2019-01-08T14:44:41.516Z (playframew…
7fdda55 
…ork#33)

**/plugins.sbt:
    addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.21")
  **build.gradle:
    def playVersion = "2.6.21"
  **build.gradle:
        playTest "org.scalatestplus.play:scalatestplus-play_\$scalaVersion:3.1.2"
octonato pushed a commit to octonato/play-samples that referenced this issue Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-java-compile-di-example/2.6.x' int…
2119ef9 
…o 2.6.x

* play-java-compile-di-example/2.6.x: (44 commits)
  Nest play-java-compile-di-example
  Updated with template-control on 2019-02-13T20:25:39.247Z (playframework#53)
  Upgrade branch 2.6.x using TemplateControl (playframework#51)
  Updated with template-control on 2019-01-17T15:10:57.466Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-16T12:08:45.201Z   /LICENSE:     wrote /LICENSE   /NOTICE:     wrote /NOTICE   /.mergify.yml:     wrote /.mergify.yml
  Upgrade branch 2.6.x using TemplateControl (playframework#47)
  Updated with template-control on 2019-01-04T17:13:23.849Z (playframework#42)
  Remove oraclejdk10 (EOLed)
  Updated with template-control on 2018-11-29T15:50:43.084Z   /.mergify.yml:     wrote /.mergify.yml   **build.sbt:     scalaVersion := "2.12.7"
  Updated with template-control on 2018-10-08T19:11:40.693Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20")   **build.gradle:     def playVersion = "2.6.20"
  Updated with template-control on 2018-09-11T20:14:49.826Z (playframework#37)
  Updated with template-control on 2018-08-20T20:37:13.525Z (playframework#36)
  Updated with template-control on 2018-07-19T01:58:55.323Z (playframework#34)
  Updated with template-control on 2018-07-16T18:38:44.960Z (playframework#33)
  Upgrade branch 2.6.x using TemplateControl (playframework#32)
  Updated with template-control on 2018-05-27T23:54:09.062Z (playframework#31)
  Updated with template-control on 2018-04-06T19:34:57.520Z (playframework#29)
  Updated with template-control on 2018-03-02T18:56:27.911Z (playframework#28)
  Upgrade branch 2.6.x using TemplateControl (playframework#27)
  Fix cross build to sbt 1.1.0 (playframework#26)
  ...
octonato pushed a commit to octonato/play-samples that referenced this issue Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-java-forms-example/2.6.x' into 2.6.x
b9baa5e 
* play-java-forms-example/2.6.x: (40 commits)
  Nest play-java-forms-example
  Updated with template-control on 2019-02-13T20:25:39.587Z (playframework#53)
  Upgrade branch 2.6.x using TemplateControl (playframework#51)
  Updated with template-control on 2019-01-17T15:10:57.484Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-16T12:08:45.857Z   /LICENSE:     wrote /LICENSE   /NOTICE:     wrote /NOTICE   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-08T14:44:41.293Z (playframework#47)
  Updated with template-control on 2019-01-04T17:13:23.788Z (playframework#42)
  Upgrade branch 2.6.x using TemplateControl (playframework#40)
  Updated with template-control on 2018-10-08T19:11:40.943Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20")   **build.gradle:     def playVersion = "2.6.20"
  Updated with template-control on 2018-09-11T20:14:49.983Z (playframework#36)
  Updated with template-control on 2018-08-20T20:37:13.462Z (playframework#35)
  Updated with template-control on 2018-07-19T01:58:55.809Z (playframework#33)
  Updated with template-control on 2018-07-16T18:38:45.455Z (playframework#32)
  Upgrade branch 2.6.x using TemplateControl (playframework#31)
  Updated with template-control on 2018-05-27T23:54:08.761Z (playframework#30)
  Updated with template-control on 2018-04-06T19:34:58.048Z (playframework#28)
  Updated with template-control on 2018-03-02T18:56:28.055Z (playframework#27)
  Upgrade branch 2.6.x using TemplateControl (playframework#26)
  Fix cross build to sbt 1.1.0 (playframework#25)
  Upgrade branch 2.6.x using TemplateControl (playframework#24)
  ...
octonato pushed a commit to octonato/play-samples that referenced this issue Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-scala-forms-example/2.6.x' into 2.6.x
68faf34 
* play-scala-forms-example/2.6.x: (43 commits)
  Nest play-scala-forms-example
  Updated with template-control on 2019-02-13T20:25:39.527Z (playframework#57)
  Upgrade branch 2.6.x using TemplateControl (playframework#55)
  Updated with template-control on 2019-01-17T15:10:57.862Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-16T12:08:45.677Z   /LICENSE:     wrote /LICENSE   /NOTICE:     wrote /NOTICE   /.mergify.yml:     wrote /.mergify.yml   **build.gradle:         playTest "org.scalatestplus.play:scalatestplus-play_$scalaVersion:3.1.2"
  Updated with template-control on 2019-01-08T14:44:42.058Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.21")   **build.gradle:     def playVersion = "2.6.21"   **build.gradle:         playTest "org.scalatestplus.play:scalatestplus-play_\$scalaVersion:3.1.2"
  Updated with template-control on 2019-01-04T17:13:23.715Z (playframework#48)
  Upgrade branch 2.6.x using TemplateControl (playframework#47)
  Updated with template-control on 2018-10-08T19:11:40.851Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20")   **build.gradle:     def playVersion = "2.6.20"
  Updated with template-control on 2018-09-11T20:14:49.844Z (playframework#43)
  Updated with template-control on 2018-08-20T20:37:13.701Z (playframework#42)
  Updated with template-control on 2018-07-19T01:58:55.810Z (playframework#40)
  Updated with template-control on 2018-07-16T18:38:45.350Z (playframework#39)
  Upgrade branch 2.6.x using TemplateControl (playframework#38)
  Updated with template-control on 2018-05-27T23:54:09.254Z (playframework#37)
  Updated with template-control on 2018-04-06T19:34:57.899Z (playframework#34)
  Updated with template-control on 2018-03-02T18:56:27.993Z (playframework#33)
  Upgrade branch 2.6.x using TemplateControl (playframework#32)
  Fix cross build to sbt 1.1.0 (playframework#31)
  Fixed typos, formatting (playframework#30)
  ...
octonato pushed a commit to octonato/play-samples that referenced this issue Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-scala-log4j2-example/2.6.x' into 2…
3adb946 
….6.x

* play-scala-log4j2-example/2.6.x: (36 commits)
  Nest play-scala-log4j2-example
  Updated with template-control on 2019-02-13T20:25:39.787Z (playframework#39)
  Upgrade branch 2.6.x using TemplateControl (playframework#37)
  Updated with template-control on 2019-01-17T15:10:57.918Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-16T12:08:45.730Z   /LICENSE:     wrote /LICENSE   /NOTICE:     wrote /NOTICE   /.mergify.yml:     wrote /.mergify.yml   **build.gradle:         playTest "org.scalatestplus.play:scalatestplus-play_$scalaVersion:3.1.2"
  Updated with template-control on 2019-01-08T14:44:41.516Z (playframework#33)
  Updated with template-control on 2019-01-04T17:13:24.081Z (playframework#28)
  Remove JDK 9 & 10
  Updated with template-control on 2018-11-29T15:50:43.150Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2018-10-08T19:11:41.210Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20")   **build.gradle:     def playVersion = "2.6.20"
  Updated with template-control on 2018-09-11T20:14:50.549Z (playframework#23)
  set log4j2.xml as javaOptions (playframework#20)
  Updated with template-control on 2018-08-20T20:37:13.971Z (playframework#22)
  Updated with template-control on 2018-07-19T01:58:55.708Z (playframework#19)
  Updated with template-control on 2018-07-16T18:38:45.739Z (playframework#18)
  Upgrade branch 2.6.x using TemplateControl (playframework#17)
  Updated with template-control on 2018-05-27T23:54:08.860Z (playframework#16)
  Updated with template-control on 2018-04-06T19:34:58.294Z (playframework#14)
  Updated with template-control on 2018-03-02T18:56:28.624Z (playframework#13)
  Upgrade branch 2.6.x using TemplateControl (playframework#12)
  ...
@mkurz
Copy link
Member

mkurz commented Mar 4, 2023

Pretty sure we can close this, both Scala and Java grpc example run and are tested in CI.

@mkurz mkurz closed this as completed Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dwijnand @octonato @mkurz