Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trailing slashes. Guide was misleading. #47

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Remove trailing slashes. Guide was misleading. #47

merged 1 commit into from
Aug 21, 2019

Conversation

ignasi35
Copy link
Member

This is already correct on the scala counterpart.

@ignasi35 ignasi35 mentioned this pull request Aug 21, 2019
Merged
@dwijnand dwijnand merged commit 13a51e0 into playframework:2.8.x Aug 21, 2019
ignasi35 added a commit that referenced this pull request Aug 21, 2019
@ignasi35
Remove trailing slashes. Guide was misleading. (bp #47)
cb8a767
@ignasi35
Copy link
Member Author

backported cb8a767

dwijnand added a commit that referenced this pull request Oct 16, 2019
@dwijnand
Merge branch '2.7.x' into 2.8.x
df1b890 
* 2.7.x: (50 commits)
  .travis.yml: Use latest AdoptOpenJDK 8
  updated to sbt 1.3.2
  Renew certificates (#54)
  update to sbt 1.3.0
  sbt 1.3.0-RC5
  adds change to fix warning 'warning: value H2Driver in package driver is deprecated (since 3.2): Use object `slick.jdbc.H2Profile` instead of `slick.driver.H2Driver`'
  Remove trailing slashes. Guide was misleading. (bp #47)
  Add new test
  Update links
  Display favicon in browser (see #35 for details)
  sbt 1.3.0-RC3
  fix comment for logout action: removing secret key => session id
  Fix wrong link
  Gatling validation for Scala REST sample
  Update gatling
  Add gatling logging configuration
  Fix readme and docs small issues
  Remove invalid param
  Scala REST: build using Scala 2.13
  Document how to run Gatling tests
  ...
octonato added a commit to octonato/play-samples that referenced this pull request Dec 4, 2019
@octonato @marcospereira
Upgrade branch 2.6.x using TemplateControl (playframework#47)
f8cfe1d 
* Updated with template-control on 2018-11-29T15:50:43.341Z
  /.mergify.yml:
    wrote /.mergify.yml
  **build.sbt:
    scalaVersion := "2.12.7"

* Remove JDK 9 & 10
octonato added a commit to octonato/play-samples that referenced this pull request Dec 4, 2019
@octonato @mergify
Upgrade branch 2.6.x using TemplateControl (playframework#47)
b57ee10 
* Updated with template-control on 2019-01-08T14:44:41.399Z
  **/plugins.sbt:
    addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.21")
  **build.gradle:
    def playVersion = "2.6.21"

* remove cross compilation to align with travis
octonato added a commit to octonato/play-samples that referenced this pull request Dec 4, 2019
@octonato @mergify
Updated with template-control on 2019-01-08T14:44:41.293Z (playframew…
577311f 
…ork#47)

**/plugins.sbt:
    addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.21")
  **build.gradle:
    def playVersion = "2.6.21"
octonato pushed a commit to octonato/play-samples that referenced this pull request Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-java-chatroom-example/2.6.x' into …
481207e 
…2.6.x

* play-java-chatroom-example/2.6.x: (51 commits)
  Nest play-java-chatroom-example
  Updated with template-control on 2019-02-13T20:25:39.277Z (playframework#67)
  Updated with template-control on 2019-02-01T10:40:33.488Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-17T15:10:57.471Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-16T12:08:45.036Z   /LICENSE:     wrote /LICENSE   /NOTICE:     wrote /NOTICE   /.mergify.yml:     wrote /.mergify.yml   **build.gradle:         play "org.webjars:webjars-play_$scalaVersion:2.6.2
  Updated with template-control on 2019-01-08T14:44:41.317Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.21")   **build.gradle:     def playVersion = "2.6.21"
  Updated with template-control on 2019-01-04T17:13:23.708Z (playframework#56)
  Upgrade branch 2.6.x using TemplateControl (playframework#55)
  Updated with template-control on 2018-10-08T19:11:40.600Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20")   **build.gradle:     def playVersion = "2.6.20"
  Updated with template-control on 2018-09-11T20:14:50.294Z (playframework#51)
  Updated with template-control on 2018-08-20T20:37:13.643Z (playframework#50)
  Updated with template-control on 2018-07-19T01:58:55.527Z (playframework#48)
  Updated with template-control on 2018-07-16T18:38:45.479Z (playframework#47)
  Upgrade branch 2.6.x using TemplateControl (playframework#45)
  Updated with template-control on 2018-05-27T23:54:08.695Z (playframework#44)
  Updated with template-control on 2018-04-06T19:34:57.877Z (playframework#43)
  Updated with template-control on 2018-03-02T18:56:27.909Z (playframework#42)
  Upgrade branch 2.6.x using TemplateControl (playframework#41)
  Fix cross build to sbt 1.1.0 (playframework#40)
  Upgrade branch 2.6.x using TemplateControl (playframework#39)
  ...
octonato pushed a commit to octonato/play-samples that referenced this pull request Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-java-compile-di-example/2.6.x' int…
2119ef9 
…o 2.6.x

* play-java-compile-di-example/2.6.x: (44 commits)
  Nest play-java-compile-di-example
  Updated with template-control on 2019-02-13T20:25:39.247Z (playframework#53)
  Upgrade branch 2.6.x using TemplateControl (playframework#51)
  Updated with template-control on 2019-01-17T15:10:57.466Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-16T12:08:45.201Z   /LICENSE:     wrote /LICENSE   /NOTICE:     wrote /NOTICE   /.mergify.yml:     wrote /.mergify.yml
  Upgrade branch 2.6.x using TemplateControl (playframework#47)
  Updated with template-control on 2019-01-04T17:13:23.849Z (playframework#42)
  Remove oraclejdk10 (EOLed)
  Updated with template-control on 2018-11-29T15:50:43.084Z   /.mergify.yml:     wrote /.mergify.yml   **build.sbt:     scalaVersion := "2.12.7"
  Updated with template-control on 2018-10-08T19:11:40.693Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20")   **build.gradle:     def playVersion = "2.6.20"
  Updated with template-control on 2018-09-11T20:14:49.826Z (playframework#37)
  Updated with template-control on 2018-08-20T20:37:13.525Z (playframework#36)
  Updated with template-control on 2018-07-19T01:58:55.323Z (playframework#34)
  Updated with template-control on 2018-07-16T18:38:44.960Z (playframework#33)
  Upgrade branch 2.6.x using TemplateControl (playframework#32)
  Updated with template-control on 2018-05-27T23:54:09.062Z (playframework#31)
  Updated with template-control on 2018-04-06T19:34:57.520Z (playframework#29)
  Updated with template-control on 2018-03-02T18:56:27.911Z (playframework#28)
  Upgrade branch 2.6.x using TemplateControl (playframework#27)
  Fix cross build to sbt 1.1.0 (playframework#26)
  ...
octonato pushed a commit to octonato/play-samples that referenced this pull request Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-java-dagger2-example/2.6.x' into 2…
2541220 
….6.x

* play-java-dagger2-example/2.6.x: (54 commits)
  Nest play-java-dagger2-example
  Updated with template-control on 2019-02-13T20:17:46.578Z (playframework#68)
  Updated with template-control on 2019-02-01T10:40:33.806Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-17T15:10:57.939Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-16T12:08:46.044Z   /LICENSE:     wrote /LICENSE   /NOTICE:     wrote /NOTICE   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-08T14:44:41.654Z (playframework#62)
  Updated with template-control on 2019-01-04T17:13:23.822Z (playframework#57)
  Upgrade branch 2.6.x using TemplateControl (playframework#55)
  Updated with template-control on 2018-10-08T19:11:41.278Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20")   **build.gradle:     def playVersion = "2.6.20"
  Updated with template-control on 2018-09-11T20:14:50.057Z (playframework#51)
  Updated with template-control on 2018-08-20T20:37:13.729Z (playframework#50)
  Updated with template-control on 2018-07-19T01:58:55.841Z (playframework#48)
  Updated with template-control on 2018-07-16T18:38:45.352Z (playframework#47)
  Upgrade branch 2.6.x using TemplateControl (playframework#46)
  Updated with template-control on 2018-05-27T23:54:09.491Z (playframework#45)
  Updated with template-control on 2018-04-06T19:34:57.948Z (playframework#43)
  Updated with template-control on 2018-03-02T18:56:28.165Z (playframework#41)
  Upgrade branch 2.6.x using TemplateControl (playframework#40)
  Fix cross build to sbt 1.1.0 (playframework#39)
  Upgrade branch 2.6.x using TemplateControl (playframework#38)
  ...
octonato pushed a commit to octonato/play-samples that referenced this pull request Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-java-fileupload-example/2.6.x' int…
9d92639 
…o 2.6.x

* play-java-fileupload-example/2.6.x: (47 commits)
  Nest play-java-fileupload-example
  Updated with template-control on 2019-02-13T20:25:39.476Z (playframework#76)
  Upgrade branch 2.6.x using TemplateControl (playframework#74)
  Upgrade branch 2.6.x using TemplateControl (playframework#73)
  Upgrade branch 2.6.x using TemplateControl (playframework#72)
  Updated with template-control on 2019-01-08T14:44:42.021Z (playframework#70)
  Updated with template-control on 2019-01-04T17:13:23.621Z (playframework#65)
  Upgrade branch 2.6.x using TemplateControl (playframework#64)
  Upgrade branch 2.6.x using TemplateControl (playframework#61)
  Updated with template-control on 2018-09-11T20:14:49.858Z (playframework#60)
  Updated with template-control on 2018-08-20T20:37:13.644Z (playframework#59)
  Updated with template-control on 2018-07-19T01:58:54.727Z (playframework#57)
  Updated with template-control on 2018-07-16T18:38:45.481Z (playframework#56)
  Upgrade branch 2.6.x using TemplateControl (playframework#55)
  Updated with template-control on 2018-05-27T23:54:09.370Z (playframework#54)
  Updated with template-control on 2018-04-06T19:34:57.877Z (playframework#52)
  Add explicit note on upload limit (playframework#51)
  Updated with template-control on 2018-03-02T18:56:28.047Z (playframework#49)
  Upgrade branch 2.6.x using TemplateControl (playframework#48)
  Fix cross build to sbt 1.1.0 (playframework#47)
  ...
octonato pushed a commit to octonato/play-samples that referenced this pull request Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-java-forms-example/2.6.x' into 2.6.x
b9baa5e 
* play-java-forms-example/2.6.x: (40 commits)
  Nest play-java-forms-example
  Updated with template-control on 2019-02-13T20:25:39.587Z (playframework#53)
  Upgrade branch 2.6.x using TemplateControl (playframework#51)
  Updated with template-control on 2019-01-17T15:10:57.484Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-16T12:08:45.857Z   /LICENSE:     wrote /LICENSE   /NOTICE:     wrote /NOTICE   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-08T14:44:41.293Z (playframework#47)
  Updated with template-control on 2019-01-04T17:13:23.788Z (playframework#42)
  Upgrade branch 2.6.x using TemplateControl (playframework#40)
  Updated with template-control on 2018-10-08T19:11:40.943Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20")   **build.gradle:     def playVersion = "2.6.20"
  Updated with template-control on 2018-09-11T20:14:49.983Z (playframework#36)
  Updated with template-control on 2018-08-20T20:37:13.462Z (playframework#35)
  Updated with template-control on 2018-07-19T01:58:55.809Z (playframework#33)
  Updated with template-control on 2018-07-16T18:38:45.455Z (playframework#32)
  Upgrade branch 2.6.x using TemplateControl (playframework#31)
  Updated with template-control on 2018-05-27T23:54:08.761Z (playframework#30)
  Updated with template-control on 2018-04-06T19:34:58.048Z (playframework#28)
  Updated with template-control on 2018-03-02T18:56:28.055Z (playframework#27)
  Upgrade branch 2.6.x using TemplateControl (playframework#26)
  Fix cross build to sbt 1.1.0 (playframework#25)
  Upgrade branch 2.6.x using TemplateControl (playframework#24)
  ...
octonato pushed a commit to octonato/play-samples that referenced this pull request Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-scala-chatroom-example/2.6.x' into…
e6bfc46 
… 2.6.x

* play-scala-chatroom-example/2.6.x: (52 commits)
  Nest play-scala-chatroom-example
  Updated with template-control on 2019-02-13T20:25:39.259Z (playframework#76)
  Upgrade branch 2.6.x using TemplateControl (playframework#74)
  Upgrade branch 2.6.x using TemplateControl (playframework#73)
  Upgrade branch 2.6.x using TemplateControl (playframework#72)
  Updated with template-control on 2019-01-08T14:44:41.803Z (playframework#70)
  Updated with template-control on 2019-01-04T17:13:23.812Z (playframework#65)
  Upgrade branch 2.6.x using TemplateControl (playframework#64)
  Upgrade branch 2.6.x using TemplateControl (playframework#61)
  Updated with template-control on 2018-09-11T20:14:50.057Z (playframework#60)
  Updated with template-control on 2018-08-20T20:37:13.669Z (playframework#59)
  Updated with template-control on 2018-07-19T01:58:55.835Z (playframework#57)
  Updated with template-control on 2018-07-16T18:38:45.034Z (playframework#56)
  Upgrade branch 2.6.x using TemplateControl (playframework#55)
  Updated with template-control on 2018-05-27T23:54:09.446Z (playframework#53)
  Updated with template-control on 2018-04-06T19:34:57.975Z (playframework#51)
  Updated with template-control on 2018-03-02T18:56:28.165Z (playframework#50)
  Upgrade branch 2.6.x using TemplateControl (playframework#49)
  Fix cross build to sbt 1.1.0 (playframework#48)
  Upgrade branch 2.6.x using TemplateControl (playframework#47)
  ...
octonato pushed a commit to octonato/play-samples that referenced this pull request Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-scala-forms-example/2.6.x' into 2.6.x
68faf34 
* play-scala-forms-example/2.6.x: (43 commits)
  Nest play-scala-forms-example
  Updated with template-control on 2019-02-13T20:25:39.527Z (playframework#57)
  Upgrade branch 2.6.x using TemplateControl (playframework#55)
  Updated with template-control on 2019-01-17T15:10:57.862Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-16T12:08:45.677Z   /LICENSE:     wrote /LICENSE   /NOTICE:     wrote /NOTICE   /.mergify.yml:     wrote /.mergify.yml   **build.gradle:         playTest "org.scalatestplus.play:scalatestplus-play_$scalaVersion:3.1.2"
  Updated with template-control on 2019-01-08T14:44:42.058Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.21")   **build.gradle:     def playVersion = "2.6.21"   **build.gradle:         playTest "org.scalatestplus.play:scalatestplus-play_\$scalaVersion:3.1.2"
  Updated with template-control on 2019-01-04T17:13:23.715Z (playframework#48)
  Upgrade branch 2.6.x using TemplateControl (playframework#47)
  Updated with template-control on 2018-10-08T19:11:40.851Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20")   **build.gradle:     def playVersion = "2.6.20"
  Updated with template-control on 2018-09-11T20:14:49.844Z (playframework#43)
  Updated with template-control on 2018-08-20T20:37:13.701Z (playframework#42)
  Updated with template-control on 2018-07-19T01:58:55.810Z (playframework#40)
  Updated with template-control on 2018-07-16T18:38:45.350Z (playframework#39)
  Upgrade branch 2.6.x using TemplateControl (playframework#38)
  Updated with template-control on 2018-05-27T23:54:09.254Z (playframework#37)
  Updated with template-control on 2018-04-06T19:34:57.899Z (playframework#34)
  Updated with template-control on 2018-03-02T18:56:27.993Z (playframework#33)
  Upgrade branch 2.6.x using TemplateControl (playframework#32)
  Fix cross build to sbt 1.1.0 (playframework#31)
  Fixed typos, formatting (playframework#30)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcospereira marcospereira marcospereira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ignasi35 @marcospereira @dwijnand