Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to sbt 1.3.2 #43

Merged
merged 4 commits into from
Sep 25, 2019
Merged

Update to sbt 1.3.2 #43

merged 4 commits into from
Sep 25, 2019

Conversation

eed3si9n
Copy link
Contributor

@eed3si9n eed3si9n commented Jul 23, 2019

Previously #29

@marcospereira
Copy link
Member

There is one valid failure here: play-samples-job-218705931-log.txt

[error] lmcoursier.internal.shaded.coursier.error.ResolutionError$ConflictingDependencies: Conflicting dependencies:
[error] org.webjars.npm:entities:[1.0,1.1):default(compile)
[error] org.webjars.npm:entities:[1.1.1,2):default(compile)
[error] 	at lmcoursier.internal.shaded.coursier.Resolve$.validate(Resolve.scala:394)
[error] 	at lmcoursier.internal.shaded.coursier.Resolve.validate0$1(Resolve.scala:140)
[error] 	at lmcoursier.internal.shaded.coursier.Resolve.$anonfun$ioWithConflicts0$4(Resolve.scala:184)
[error] 	at lmcoursier.internal.shaded.coursier.util.Task$.$anonfun$flatMap$2(Task.scala:14)
[error] 	at scala.concurrent.Future.$anonfun$flatMap$1(Future.scala:307)
[error] 	at scala.concurrent.impl.Promise.$anonfun$transformWith$1(Promise.scala:41)
[error] 	at scala.concurrent.impl.CallbackRunnable.run(Promise.scala:64)
[error] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[error] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[error] 	at java.lang.Thread.run(Thread.java:748)
[error] (update) lmcoursier.internal.shaded.coursier.error.ResolutionError$ConflictingDependencies: Conflicting dependencies:
[error] org.webjars.npm:entities:[1.0,1.1):default(compile)
[error] org.webjars.npm:entities:[1.1.1,2):default(compile)

Possibly related to coursier/coursier#569.

The other failure just requires a change in our script here:

sbt ++$TRAVIS_SCALA_VERSION ";project gatling;gatling:compile"

And here:

sbt ++$TRAVIS_SCALA_VERSION ";project gatling; gatling:compile"

@dwijnand
Copy link
Member

Possibly related to coursier/coursier#569.

Eugene opened coursier/coursier#1284

@dwijnand dwijnand changed the title sbt 1.3.0-RC3 [WIP] Update to sbt 1.3.0-RC3 Jul 24, 2019
@dwijnand
Copy link
Member

dwijnand commented Jul 24, 2019

The other failure just requires a change in our script here:

[error] Expected ';'
[error] No such setting/task
[error] gatling:compile
[error]                ^

@eed3si9n is this a regression? I think both ";project gatling;gatling:compile" and ";project gatling; gatling:compile" should be supported.

(edit) opened sbt/sbt#4897 to track

@eed3si9n
Copy link
Contributor Author

Yea. Multi-parser bug is fixed in develop branch.

@eed3si9n eed3si9n changed the title [WIP] Update to sbt 1.3.0-RC3 [WIP] Update to sbt 1.3.0-RC5 Aug 29, 2019
@octonato octonato changed the title [WIP] Update to sbt 1.3.0-RC5 Update to sbt 1.3.0 Sep 4, 2019
@dwijnand
Copy link
Member

dwijnand commented Sep 5, 2019

Looks like play-scala-tls-example on Scala 2.13 has failed with this upgrade:

[error] p.c.s.n.PlayRequestHandler - Exception caught in Netty
io.netty.handler.codec.DecoderException: javax.net.ssl.SSLException: Received fatal alert: certificate_unknown
	at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:472)
	at io.netty.handler.codec.ByteToMessageDecoder.channelInputClosed(ByteToMessageDecoder.java:405)
	at io.netty.handler.codec.ByteToMessageDecoder.channelInputClosed(ByteToMessageDecoder.java:372)
	at io.netty.handler.codec.ByteToMessageDecoder.channelInactive(ByteToMessageDecoder.java:355)
	at io.netty.handler.ssl.SslHandler.channelInactive(SslHandler.java:1076)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:242)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:228)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:221)
	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelInactive(DefaultChannelPipeline.java:1403)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:242)
Caused by: javax.net.ssl.SSLException: Received fatal alert: certificate_unknown
	at sun.security.ssl.Alerts.getSSLException(Alerts.java:219)
	at sun.security.ssl.SSLEngineImpl.fatal(SSLEngineImpl.java:1647)
	at sun.security.ssl.SSLEngineImpl.fatal(SSLEngineImpl.java:1615)
	at sun.security.ssl.SSLEngineImpl.recvAlert(SSLEngineImpl.java:1781)
	at sun.security.ssl.SSLEngineImpl.readRecord(SSLEngineImpl.java:1070)
	at sun.security.ssl.SSLEngineImpl.readNetRecord(SSLEngineImpl.java:896)
	at sun.security.ssl.SSLEngineImpl.unwrap(SSLEngineImpl.java:766)
	at javax.net.ssl.SSLEngine.unwrap(SSLEngine.java:624)
	at io.netty.handler.ssl.SslHandler$SslEngineType$3.unwrap(SslHandler.java:295)
	at io.netty.handler.ssl.SslHandler.unwrap(SslHandler.java:1330)
[info] ServerSpec:
[info] Server
[info] - should work fine over https *** FAILED ***
[info]   The future returned an exception of type: java.net.ConnectException, with message: General SSLEngine problem. (ServerSpec.scala:39)

@mkurz
Copy link
Member

mkurz commented Sep 20, 2019

1.3.1 released.

@eed3si9n
Copy link
Contributor Author

I'm not announcing 1.3.1 because I messed up the Bash script - sbt/sbt#5108

@octonato
Copy link
Contributor

@eed3si9n, I updated this PR. All of them on 1.3.2 now!

@octonato octonato changed the title Update to sbt 1.3.0 Update to sbt 1.3.2 Sep 23, 2019
@mkurz
Copy link
Member

mkurz commented Sep 25, 2019

Anything holding us back from merging this one?

@dwijnand dwijnand merged commit c313cbc into playframework:2.7.x Sep 25, 2019
@eed3si9n eed3si9n deleted the wip/bumpsbt branch September 29, 2019 23:01
octonato pushed a commit to octonato/play-samples that referenced this pull request Dec 4, 2019
…2.6.x

* play-java-chatroom-example/2.6.x: (51 commits)
  Nest play-java-chatroom-example
  Updated with template-control on 2019-02-13T20:25:39.277Z (playframework#67)
  Updated with template-control on 2019-02-01T10:40:33.488Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-17T15:10:57.471Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-16T12:08:45.036Z   /LICENSE:     wrote /LICENSE   /NOTICE:     wrote /NOTICE   /.mergify.yml:     wrote /.mergify.yml   **build.gradle:         play "org.webjars:webjars-play_$scalaVersion:2.6.2
  Updated with template-control on 2019-01-08T14:44:41.317Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.21")   **build.gradle:     def playVersion = "2.6.21"
  Updated with template-control on 2019-01-04T17:13:23.708Z (playframework#56)
  Upgrade branch 2.6.x using TemplateControl (playframework#55)
  Updated with template-control on 2018-10-08T19:11:40.600Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20")   **build.gradle:     def playVersion = "2.6.20"
  Updated with template-control on 2018-09-11T20:14:50.294Z (playframework#51)
  Updated with template-control on 2018-08-20T20:37:13.643Z (playframework#50)
  Updated with template-control on 2018-07-19T01:58:55.527Z (playframework#48)
  Updated with template-control on 2018-07-16T18:38:45.479Z (playframework#47)
  Upgrade branch 2.6.x using TemplateControl (playframework#45)
  Updated with template-control on 2018-05-27T23:54:08.695Z (playframework#44)
  Updated with template-control on 2018-04-06T19:34:57.877Z (playframework#43)
  Updated with template-control on 2018-03-02T18:56:27.909Z (playframework#42)
  Upgrade branch 2.6.x using TemplateControl (playframework#41)
  Fix cross build to sbt 1.1.0 (playframework#40)
  Upgrade branch 2.6.x using TemplateControl (playframework#39)
  ...
octonato pushed a commit to octonato/play-samples that referenced this pull request Dec 4, 2019
….6.x

* play-java-dagger2-example/2.6.x: (54 commits)
  Nest play-java-dagger2-example
  Updated with template-control on 2019-02-13T20:17:46.578Z (playframework#68)
  Updated with template-control on 2019-02-01T10:40:33.806Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-17T15:10:57.939Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-16T12:08:46.044Z   /LICENSE:     wrote /LICENSE   /NOTICE:     wrote /NOTICE   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-08T14:44:41.654Z (playframework#62)
  Updated with template-control on 2019-01-04T17:13:23.822Z (playframework#57)
  Upgrade branch 2.6.x using TemplateControl (playframework#55)
  Updated with template-control on 2018-10-08T19:11:41.278Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20")   **build.gradle:     def playVersion = "2.6.20"
  Updated with template-control on 2018-09-11T20:14:50.057Z (playframework#51)
  Updated with template-control on 2018-08-20T20:37:13.729Z (playframework#50)
  Updated with template-control on 2018-07-19T01:58:55.841Z (playframework#48)
  Updated with template-control on 2018-07-16T18:38:45.352Z (playframework#47)
  Upgrade branch 2.6.x using TemplateControl (playframework#46)
  Updated with template-control on 2018-05-27T23:54:09.491Z (playframework#45)
  Updated with template-control on 2018-04-06T19:34:57.948Z (playframework#43)
  Updated with template-control on 2018-03-02T18:56:28.165Z (playframework#41)
  Upgrade branch 2.6.x using TemplateControl (playframework#40)
  Fix cross build to sbt 1.1.0 (playframework#39)
  Upgrade branch 2.6.x using TemplateControl (playframework#38)
  ...
octonato pushed a commit to octonato/play-samples that referenced this pull request Dec 4, 2019
* play-scala-forms-example/2.6.x: (43 commits)
  Nest play-scala-forms-example
  Updated with template-control on 2019-02-13T20:25:39.527Z (playframework#57)
  Upgrade branch 2.6.x using TemplateControl (playframework#55)
  Updated with template-control on 2019-01-17T15:10:57.862Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-16T12:08:45.677Z   /LICENSE:     wrote /LICENSE   /NOTICE:     wrote /NOTICE   /.mergify.yml:     wrote /.mergify.yml   **build.gradle:         playTest "org.scalatestplus.play:scalatestplus-play_$scalaVersion:3.1.2"
  Updated with template-control on 2019-01-08T14:44:42.058Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.21")   **build.gradle:     def playVersion = "2.6.21"   **build.gradle:         playTest "org.scalatestplus.play:scalatestplus-play_\$scalaVersion:3.1.2"
  Updated with template-control on 2019-01-04T17:13:23.715Z (playframework#48)
  Upgrade branch 2.6.x using TemplateControl (playframework#47)
  Updated with template-control on 2018-10-08T19:11:40.851Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20")   **build.gradle:     def playVersion = "2.6.20"
  Updated with template-control on 2018-09-11T20:14:49.844Z (playframework#43)
  Updated with template-control on 2018-08-20T20:37:13.701Z (playframework#42)
  Updated with template-control on 2018-07-19T01:58:55.810Z (playframework#40)
  Updated with template-control on 2018-07-16T18:38:45.350Z (playframework#39)
  Upgrade branch 2.6.x using TemplateControl (playframework#38)
  Updated with template-control on 2018-05-27T23:54:09.254Z (playframework#37)
  Updated with template-control on 2018-04-06T19:34:57.899Z (playframework#34)
  Updated with template-control on 2018-03-02T18:56:27.993Z (playframework#33)
  Upgrade branch 2.6.x using TemplateControl (playframework#32)
  Fix cross build to sbt 1.1.0 (playframework#31)
  Fixed typos, formatting (playframework#30)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants