Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging releases #93

Closed
gslowikowski opened this issue Mar 30, 2017 · 9 comments
Closed

Tagging releases #93

gslowikowski opened this issue Mar 30, 2017 · 9 comments

Comments

@gslowikowski
Copy link

Tag every release, please.

@schmitch
Copy link
Contributor

currently this should work now, the first releases were probably untagged since sbt-release was not configured.

@gslowikowski
Copy link
Author

Can you manually create tags for previous releases?

@schmitch
Copy link
Contributor

well I don't know the actual commits, and they were probably just milestones. maybe @wsargent knows them and can do that?

@marcospereira
Copy link
Member

We still have some configurations to do, see #92.

The tagging step is not working correctly, at least no tag was pushed for M6.

@wsargent
Copy link
Member

Getting sbt-release to actually work has been non-trivial. If someone can lend a hand that would be nice...

@gmethvin
Copy link
Member

So, I did the last release (1.0.0-M6), and it turns out sbt-release created the tag locally but it didn't get pushed to remote. A git push --tags fixed that. So this seems like this a possible bug in sbt-release.

@gslowikowski
Copy link
Author

The last question in release process is "Push changes to the remote repository (y/n)? [y]". If you answer "yes" pushChanges step is performed. It calls VCS (Git in this case) pushChanges method and it should push tags.

BTW I always answer "no" to the question and push changes manually after successful release (when I see new artifacts in Maven central repo).

@marcospereira
Copy link
Member

@wsargent was this fixed by #106 and #107?

@wsargent
Copy link
Member

wsargent commented May 6, 2017

Yes 😄

@wsargent wsargent closed this as completed May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants