443 bind map #45
Closed
443 bind map #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
play.data.binding.Binder.bindInternal was failing out before letting BeanWrapper handle the binding FIXED!!! JPABinding http://localhost:9003/jpabinding/create?project.name=Sematic&project.company.name=CG77 assert text present -> CG77 FIXED!!! JPASave http://localhost:9003/horses/index click second button Blups:1 FIXED!!! ComplexBinding h.address.city.name
|
Ok merged. |
|
Great, I forgot to update the documentation... Hey, if there's anything in my pathch that just donesn't fit with the recommended practices don't hesitate to tell me saludos sas |
|
Ok you can reopen this pull request with a commit for the documentation update. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did my best to fix #443
http://play.lighthouseapp.com/projects/57987/tickets/443
I created a test CompositeMapBinding.test.html
And ran every test, I think I haven't broken anything
Unfotunately, there where two tests failing (they failed fram trunk) because of troubles with the dates and latin america locales, I presume
http://groups.google.com/group/play-framework/browse_thread/thread/b3cd7b1bd9f56f13/bda5d68d02aaac61?hl=es&lnk=gst&q=opensas+test#bda5d68d02aaac61
Unit tests.SimpleJPATest -> Fails
Selenium test.binding -> Fails
saludos
sas
pd: let me know if there's anything that could be improved... go easy on me, it's my first patch...