Code cosmetics and documentation. #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I would like to merge it, but I can't run properly 'ant test' after applying your patches. It's strange because I see nothing wrong with yours changes. Do the tests pass on your version? |
|
The tests run fine with me. When I did a checkout (tried twice, actually), there were a lot of test files with status "modified", even though I hadn't touched them. |
|
Tanks, done. |
lmcalpin
pushed a commit
to lmcalpin/play
that referenced
this pull request
Apr 19, 2011
solti
added a commit
to solti/play
that referenced
this pull request
Nov 8, 2011
If your default language is "en" and you change to that language, then the defauls should be loaded! Before this fix they were not.
solti
added a commit
to solti/play
that referenced
this pull request
Nov 14, 2011
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functionality changes.