-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asset changes in subprojects #12484
Comments
Hallo, Any news about a fix? greetings Rami |
Hallo, working on it in |
I found the cause and a fix is underway: |
Until the next Play patch release is out you can fix this by upgrading to latest webjars-locator-core, just put in your // Can be removed when Play 2.9.4/3.0.4 is released
libraryDependencies += "org.webjars" % "webjars-locator-core" % "0.59" Let me now if this works for you. |
Contains webjars/webjars-locator-core#159 to fix #12484 (cherry picked from commit 6b295a3)
Contains webjars/webjars-locator-core#159 to fix #12484 (cherry picked from commit 6b295a3) # Conflicts: # project/Dependencies.scala
Contains webjars/webjars-locator-core#159 to fix #12484 (cherry picked from commit 6b295a3) # Conflicts: # project/Dependencies.scala
Contains webjars/webjars-locator-core#159 to fix #12484 (cherry picked from commit 6b295a3) # Conflicts: # project/Dependencies.scala
Works for us! |
Great! This will work in next Play's patch release out of the box. |
Play Version
3.0.2
API
Java
Operating System
Windows 10
behavior on other OSes is unknown
JDK
openjdk version "17.0.10" 2024-01-16
OpenJDK Runtime Environment (build 17.0.10+7-Ubuntu-122.04.1)
OpenJDK 64-Bit Server VM (build 17.0.10+7-Ubuntu-122.04.1, mixed mode, sharing)
Library Dependencies
Expected Behavior
Actual Behavior
Reproducible Test Case
https://github.com/n4cer/playSubprojects_3-0
Description
We have divided a project into 3 subprojects: "common, website, and admin".
Our assets are located in the common module.
Since play 2.9/3.0, we have encountered an issue where changes to these assets are no longer detected in dev mode.
Without "clean", the changes are not applied. If we move the assets to the root project, dev mode works as expected again. However, this results in the assets being missing from the dist packages of admin and website.
The text was updated successfully, but these errors were encountered: