Update changed assets in subprojects

[mkurz]

Fixes

• Asset changes in subprojects #12484
• Issue with sbt-web/sassify, sub-projects, and the Play dev server... #12636

To confirm the problem, I first push a scripted test that will fail without the fix from

• If WebJar version is a "-snapshot", overwrite existing files when extracting webjars/webjars-locator-core#159

[mkurz]

As expected the newly added scripted test fails.

click for log

[info] Resource at /assets/stylesheets/main.css returned 200 as expected
[info] Resource at /assets/stylesheets/main.css contained margin-top: 50px;
[info] [success] Total time: 3 s, completed Jun 10, 2024, 9:00:34 AM
[info] Attempt 0 at /assets/stylesheets/main.css
[info] [info] LESS compiling on 1 source(s)
[info] Got exception: java.lang.RuntimeException: Resource at /assets/stylesheets/main.css didn't contain 'margin-top: 51px;':
[info] /*
[info]  * Copyright (C) from 2022 The Play Framework Contributors <https://github.com/playframework>, 2011-2021 Lightbend Inc. <https://www.lightbend.com>
[info]  */
[info] body {
[info]   margin-top: 50px;
[info] }
[info] . Cause was null
[info] Attempt 1 at /assets/stylesheets/main.css
[info] Got exception: java.lang.RuntimeException: Resource at /assets/stylesheets/main.css didn't contain 'margin-top: 51px;':
[info] /*
[info]  * Copyright (C) from 2022 The Play Framework Contributors <https://github.com/playframework>, 2011-2021 Lightbend Inc. <https://www.lightbend.com>
[info]  */
[info] body {
[info]   margin-top: 50px;
[info] }
[info] . Cause was null
[info] Attempt 2 at /assets/stylesheets/main.css
[info] Got exception: java.lang.RuntimeException: Resource at /assets/stylesheets/main.css didn't contain 'margin-top: 51px;':
[info] /*
[info]  * Copyright (C) from 2022 The Play Framework Contributors <https://github.com/playframework>, 2011-2021 Lightbend Inc. <https://www.lightbend.com>
[info]  */
[info] body {
[info]   margin-top: 50px;
[info] }
[info] . Cause was null
[info] Attempt 3 at /assets/stylesheets/main.css
[info] Got exception: java.lang.RuntimeException: Resource at /assets/stylesheets/main.css didn't contain 'margin-top: 51px;':
[info] /*
[info]  * Copyright (C) from 2022 The Play Framework Contributors <https://github.com/playframework>, 2011-2021 Lightbend Inc. <https://www.lightbend.com>
[info]  */
[info] body {
[info]   margin-top: 50px;
[info] }
[info] . Cause was null
[info] Attempt 4 at /assets/stylesheets/main.css
[info] Got exception: java.lang.RuntimeException: Resource at /assets/stylesheets/main.css didn't contain 'margin-top: 51px;':
[info] /*
[info] [error] 	at play.sbt.scriptedtools.ScriptedTools$.$anonfun$verifyResourceContainsImpl$1(ScriptedTools.scala:106)
[info] [error] 	at scala.collection.immutable.List.foreach(List.scala:431)
[info] [error] 	at play.sbt.scriptedtools.ScriptedTools$.verifyResourceContainsImpl(ScriptedTools.scala:104)
[info] [error] 	at play.sbt.scriptedtools.ScriptedTools$.verifyResourceContains(ScriptedTools.scala:78)
[info] [error] 	at $92c707ab781c35981ff2$.$anonfun$root$4(build.sbt:11)
[info] [error] 	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
[info] [error] 	at sbt.std.Transform$$anon$3.$anonfun$apply$2(Transform.scala:47)
[info] [error] 	at sbt.std.Transform$$anon$4.work(Transform.scala:69)
[info] [error] 	at sbt.Execute.$anonfun$submit$2(Execute.scala:283)
[info] [error] 	at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:24)
[info] [error] 	at sbt.Execute.work(Execute.scala:292)
[info] [error] 	at sbt.Execute.$anonfun$submit$1(Execute.scala:283)
[info] [error] 	at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:265)
[info] [error] 	at sbt.CompletionService$$anon$2.call(CompletionService.scala:65)
[info] [error] 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[info] [error] 	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
[info] [error] 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[info] [error] 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
[info] [error] 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
[info] [error] 	at java.base/java.lang.Thread.run(Thread.java:833)
[info] [error] (verifyResourceContains) Resource at /assets/stylesheets/main.css didn't contain 'margin-top: 51px;':
[info] [error] /*
[info] [error]  * Copyright (C) from 2022 The Play Framework Contributors <https://github.com/playframework>, 2011-2021 Lightbend Inc. <https://www.lightbend.com>
[info] [error]  */
[info] [error] body {
[info] [error]   margin-top: 50px;
[info] [error] }
[info] [error] Total time: 16 s, completed Jun 10, 2024, 9:00:50 AM
Error:  x play-sbt-plugin/asset-changes-in-subprojects 
Error:   Cause of test exception: {line 4}  Command failed: verifyResourceContains failed

Pushing the latest webjars-locator-core should fix it.

[mkurz]

It works (just like locally 😉)

[mkurz]

@Mergifyio backport 3.0.x

[mkurz]

@Mergifyio backport 2.9.x

[mergify]

backport 3.0.x

✅ Backports have been created

• #12724 [3.0.x] Update changed assets in subprojects (backport #12721) by @mkurz has been created for branch 3.0.x

[mergify]

backport 2.9.x

✅ Backports have been created

• #12725 [2.9.x] Update changed assets in subprojects (backport #12721) by @mkurz has been created for branch 2.9.x but encountered conflicts