Restore Jackson visibility defaults #10526
Conversation
|
@Mergifyio backport master |
|
Command
|
| @@ -36,7 +37,9 @@ class ObjectMapperProvider @Inject() (lifecycle: ApplicationLifecycle, actorSyst | |||
| JacksonObjectMapperProvider | |||
| .get(actorSystem) | |||
| .getOrCreate(ObjectMapperProvider.BINDING_NAME, Option.empty) | |||
| mapper.setVisibility(PropertyAccessor.FIELD, JsonAutoDetect.Visibility.PUBLIC_ONLY) | |||
There was a problem hiding this comment.
I wonder if there are other default settings we should set?
There was a problem hiding this comment.
Yeah, good point. This is the only default I could find that changed but maybe keeping a full, explicit setup of the returned instance will prevent future changes in behavior from the Play user point of view. I'd do it on a separate PR, though.
|
I wonder if this change won’t override customizations made at akka serialization configs? Other question, maybe a test to make sure that does not happen again? Or is this just intended to be temporary fix? |
|
I assume the goal here is to eventually merge akka/akka#29797, will provide a better long term fix. |
|
I'll rewrite the description of the PR to better explain my intent (it was a Friday evening and I was on a hurry). |
There was a problem hiding this comment.
LGTM, though I don't think we should revert it.
I may be missing some more background, but as I understand it we want it to explicitly set the PUBLIC_ONLY for the binding named "play".
The Akka one should be kept as is in case inter-node messages are being serialized with Jackson. If we get the fix from akka/akka#29797 and change the visibility in the orrverides we will be affecting all messages, not only API messages. Am I correct?
The changes in akka/akka#29797 are not affecting any message. The behavior is maintained. With akka/akka#29797 in place, users will gain a mechanism to change the visibility of all |
|
The CLA Validator check is missing in action. I'll manually merge as there are 2 approvals already. |
|
Command
|
Restore Jackson visibility defaults (bp #10526)
Try to ensure the
ObjectMappermanaged by Akka and identified as"play"uses the same defaults anObjectMapperprovided in Play 2.7.This is a quick solution we may or may not merge (and just keep as inspiration for users to implement their workaround). The long-term solution is to wait for akka/akka#29797 and set the visibility default for
"play"'sObjectMapperinreference-override.conf; and then, undo the workaround inObjectMapperModuleintroduced in this PR.Refs #10523
see also akka/akka#29797