Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Scala 3 to crossbuild #394

Closed
wants to merge 7 commits into from
Closed

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Feb 10, 2021

includes commits from #393 — I'll rebase this one once that one's merged

references #390

@SethTisue
Copy link
Member Author

status: this is still in early stages, I am still just chewing through bread and have yet to take a bite of meat

build.sbt Outdated Show resolved Hide resolved
Copy link
Contributor

@sullis sullis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ScalaTest 3.2.5

@SethTisue
Copy link
Member Author

Travis-CI config seems messed up, there is Scala 3 stuff in the Scala 2 jobs...

@SethTisue
Copy link
Member Author

just a note that I haven't forgotten about this. I've been working on play-json instead, but this is next in line.

@SethTisue SethTisue mentioned this pull request Apr 14, 2021
@SethTisue
Copy link
Member Author

Travis-CI config seems messed up, there is Scala 3 stuff in the Scala 2 jobs

Fixed now. But there are still two non-Scala 3 problems.

The plugin test job fails with Conflicting cross-version suffixes

And also, MiMa is failing:

[error] twirl-parser: Failed binary compatibility check against com.typesafe.play:twirl-parser_2.12:1.5.0! Found 1 potential problems
[error]  * method several(scala.Function0,scala.collection.mutable.Buffer,scala.reflect.Manifest)scala.collection.mutable.Buffer in class play.twirl.parser.TwirlParser's type is different in current version, where it is (scala.Function0,scala.collection.mutable.Buffer,scala.reflect.ClassTag)scala.collection.mutable.Buffer instead of (scala.Function0,scala.collection.mutable.Buffer,scala.reflect.Manifest)scala.collection.mutable.Buffer
[error]    filter with: ProblemFilters.exclude[IncompatibleMethTypeProblem]("play.twirl.parser.TwirlParser.several")

@SethTisue SethTisue changed the title WIP: Scala 3 add Scala 3 to crossbuild Jul 29, 2021
@SethTisue
Copy link
Member Author

SethTisue commented Jul 29, 2021

me up in .travis.yml trying to understand how matrix: and stage: interact:

tenor

@SethTisue
Copy link
Member Author

Man, I hate builds that have an sbt plugin subproject mixed in with crossbuilt subprojects. It makes sense for such builds to exist, but 🙀

@SethTisue
Copy link
Member Author

I think I got the CI matrix sorted out, including the plugin tests. I don't like omitting plugin from the root project aggregate, but I don't know how to improve that.

So what remains here is:

  • MiMa is failing because Manifest vs ClassTag. I guess we ought to just bite the bullet here and get off Manifest, even if it means accepting the binary incompatibility and bumping the major version?
  • the actual Scala 3 work

@SethTisue
Copy link
Member Author

Still chipping away at this. A lot of PRs (mostly version bumps) were merged since I initially submitted this, so I rebased. And then I made separate scala-2 and scala-3 source directories with just the version-dependent bits in them, but right now the Scala 3 ones are just ??? stubs.

@SethTisue
Copy link
Member Author

abandoning; someone else is free to pick it up

@SethTisue SethTisue closed this Oct 5, 2021
@SethTisue
Copy link
Member Author

some of the context for this is at https://discuss.lightbend.com/t/github-project-abandonned/8781/12, by the way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants