Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Prettier #72

Merged
merged 7 commits into from
May 12, 2021
Merged

Prettier #72

merged 7 commits into from
May 12, 2021

Conversation

mskelton
Copy link
Member

Fixes #71

@mxschmitt In #71 you mentioned wanting to use the default settings of Prettier. The only except to that in this PR is semicolons. I observed that the majority of this repo doesn't use semis, so I turned off that rule. If you would like me to leave it fully default, totally fine but it will increase the diff a little bit.

@mskelton mskelton marked this pull request as ready for review May 12, 2021 14:28
.github/workflows/nodejs.yml Outdated Show resolved Hide resolved
mskelton and others added 2 commits May 12, 2021 09:31
Co-authored-by: Max Schmitt <max@schmitt.mx>
@codecov-commenter
Copy link

Codecov Report

Merging #72 (77909db) into master (bd931ff) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   99.30%   99.37%   +0.07%     
==========================================
  Files          10       10              
  Lines         144      161      +17     
  Branches       27       27              
==========================================
+ Hits          143      160      +17     
  Misses          1        1              
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
src/matchers/index.ts 100.00% <100.00%> (ø)
src/matchers/toEqualText/index.ts 100.00% <100.00%> (ø)
src/matchers/toEqualUrl/index.ts 100.00% <100.00%> (ø)
src/matchers/toEqualValue/index.ts 100.00% <100.00%> (ø)
src/matchers/toHaveFocus/index.ts 100.00% <100.00%> (ø)
src/matchers/toHaveSelector/index.ts 100.00% <100.00%> (ø)
src/matchers/toHaveSelectorCount/index.ts 100.00% <100.00%> (ø)
src/matchers/toHaveText/index.ts 100.00% <100.00%> (ø)
src/matchers/utils.ts 97.95% <100.00%> (+0.08%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd931ff...77909db. Read the comment docs.

@mxschmitt mxschmitt merged commit db7a938 into playwright-community:master May 12, 2021
@mskelton mskelton deleted the prettier branch May 12, 2021 14:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce automated code formatting
3 participants