Skip to content

Commit

Permalink
tree-optimization/106081 - elide redundant permute
Browse files Browse the repository at this point in the history
The following patch makes sure to elide a redundant permute that
can be merged with existing splats represented as load permutations
as we now do for non-grouped SLP loads.  This is the last bit
missing to fix this PR where the main fix was already done by
r14-2117-gdd86a5a69cbda4

Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed.

	PR tree-optimization/106081
	* tree-vect-slp.cc (vect_optimize_slp_pass::start_choosing_layouts):
	Assign layout -1 to splats.

	* gcc.dg/vect/pr106081.c: New testcase.
  • Loading branch information
rguenth authored and ouuleilei-bot committed Jul 26, 2023
1 parent c2d62cd commit 76f66d4
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 1 deletion.
33 changes: 33 additions & 0 deletions gcc/testsuite/gcc.dg/vect/pr106081.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
/* { dg-do compile } */
/* { dg-additional-options "-ffast-math -fdump-tree-optimized" } */
/* { dg-additional-options "-mavx2" { target x86_64-*-* i?86-*-* } } */
/* { dg-require-effective-target vect_double } */
/* { dg-require-effective-target vect_unpack } */
/* { dg-require-effective-target vect_intdouble_cvt } */
/* { dg-require-effective-target vect_perm } */

struct pixels
{
short a,b,c,d;
} *pixels;
struct dpixels
{
double a,b,c,d;
};

double
test(double *k)
{
struct dpixels results={};
for (int u=0; u<1000*16;u++,k--)
{
results.a += *k*pixels[u].a;
results.b += *k*pixels[u].b;
results.c += *k*pixels[u].c;
results.d += *k*pixels[u].d;
}
return results.a+results.b*2+results.c*3+results.d*4;
}

/* { dg-final { scan-tree-dump "vectorized 1 loops" "vect" } } */
/* { dg-final { scan-tree-dump-times "VEC_PERM" 4 "optimized" { target x86_64-*-* i?86-*-* } } } */
5 changes: 4 additions & 1 deletion gcc/tree-vect-slp.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4583,7 +4583,10 @@ vect_optimize_slp_pass::start_choosing_layouts ()
IFN_MASK_LOADs). */
gcc_assert (partition.layout == 0 && !m_slpg->vertices[node_i].succ);
if (!STMT_VINFO_GROUPED_ACCESS (dr_stmt))
continue;
{
partition.layout = -1;
continue;
}
dr_stmt = DR_GROUP_FIRST_ELEMENT (dr_stmt);
imin = DR_GROUP_SIZE (dr_stmt) + 1;
tmp_perm.safe_splice (SLP_TREE_LOAD_PERMUTATION (node));
Expand Down

0 comments on commit 76f66d4

Please sign in to comment.