can specify the output format as text or json #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterebden
reviewed
Apr 8, 2024
goddenrich
force-pushed
the
output-format
branch
2 times, most recently
from
be08655
to
7227a28
Compare
goddenrich
force-pushed
the
output-format
branch
from
7227a28
to
2fb1024
Compare
goddenrich
commented
Apr 9, 2024
| @@ -122,12 +123,24 @@ func (g *Graph) loadFile(path string) (*build.File, error) { | |||
| return build.ParseBuild(validFilename, nil) | |||
| } | |||
|
|
|||
| func (g *Graph) FormatFiles(write bool, out io.Writer) error { | |||
| func (g *Graph) FormatFilesWithWriter(out io.Writer, format string) error { | |||
There was a problem hiding this comment.
maybe should be FormatFilesToWriter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously we would print the contents of the updated formatted build files to stdout as text. It can be useful for linters to be able to output as json for easier parsing especially when multiple files are updated at once.