Remove replace directive labels when not needed #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bels are cleaned up
…a replace directive, it does not need a label!
…individual rule methods for additional clarity
goddenrich
approved these changes
Jul 15, 2024
…atching replace directive
goddenrich
approved these changes
Jul 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR I made, #114, added
go_replace_directivelabels to all go_repo rules which had a replace directive in the go.mod file. But it did not remove that label from any rules which do not have a go.mod replace directive.(Also, it added go_replace_directive labels to any new rules without replace directives, whoops)
Extended tests, and fixed functionality to ensure that go_replace_directive labels are removed from all rules which lack replace directives in the go.mod file