Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

Make editor legacy #417

Merged
merged 4 commits into from
Jul 20, 2022
Merged

Make editor legacy #417

merged 4 commits into from
Jul 20, 2022

Conversation

Darmody
Copy link
Contributor

@Darmody Darmody commented Jul 19, 2022

  1. rename packages/editor to packages/legacy-editor
  2. create new package packages/editor

More details:

#276
#378

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #417 (f08aa4a) into main (ab8bb32) will increase coverage by 0.03%.
The diff coverage is 93.33%.

❗ Current head f08aa4a differs from pull request most recent head 3e75f98. Consider uploading reports for the commit 3e75f98 to get more accurate results

@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
+ Coverage   69.29%   69.33%   +0.03%     
==========================================
  Files        1055     1057       +2     
  Lines       17939    17946       +7     
  Branches     2475     2475              
==========================================
+ Hits        12431    12442      +11     
+ Misses       5203     5199       -4     
  Partials      305      305              
Flag Coverage Δ
frontend-unit 64.83% <93.33%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...legacy/common/components/TopbarMore/index.style.ts 0.00% <ø> (ø)
...-web/src/docs_legacy/pages/DocumentContentPage.tsx 0.00% <ø> (ø)
.../client-web/src/docs_legacy/pages/DocumentPage.tsx 0.00% <ø> (ø)
.../src/docs_legacy/pages/hooks/useDocSyncProvider.ts 0.00% <ø> (ø)
...useEditorOptions/useDiscussion/useCreateComment.ts 0.00% <ø> (ø)
...itorOptions/useDiscussion/useCreateConversation.ts 0.00% <ø> (ø)
...itorOptions/useDiscussion/useDeleteConversation.ts 0.00% <ø> (ø)
...ks/useEditorOptions/useDiscussion/useDiscussion.ts 0.00% <ø> (ø)
...EditorOptions/useDiscussion/useGetConversations.ts 0.00% <ø> (ø)
...EditorOptions/useDiscussion/useOpenConversation.ts 0.00% <ø> (ø)
... and 516 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab8bb32...3e75f98. Read the comment docs.

@Darmody Darmody temporarily deployed to pr_preview July 19, 2022 14:32 Inactive
@github-actions
Copy link
Contributor

This pull request has been built and is available for preview at pr417.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

@Darmody Darmody enabled auto-merge (squash) July 19, 2022 14:46
0xDing
0xDing previously approved these changes Jul 20, 2022
stackia
stackia previously approved these changes Jul 20, 2022
@Darmody Darmody merged commit f082d65 into main Jul 20, 2022
@Darmody Darmody deleted the make-editor-legacy branch July 20, 2022 08:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants