Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

feat(trash): quick solution for restoring subpage #162 #421

Merged
merged 33 commits into from
Jul 20, 2022
Merged

feat(trash): quick solution for restoring subpage #162 #421

merged 33 commits into from
Jul 20, 2022

Conversation

aligo
Copy link
Contributor

@aligo aligo commented Jul 20, 2022

#162 For now we just simply hide/disable restore button/checkbox for page which its parent deleted as a quick solution.
In future there will be more Trash UI tweaks to improve this.

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #421 (1dae5e0) into main (09b5ff9) will decrease coverage by 0.00%.
The diff coverage is 51.42%.

@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
- Coverage   69.30%   69.30%   -0.01%     
==========================================
  Files        1055     1057       +2     
  Lines       17933    17957      +24     
  Branches     2475     2476       +1     
==========================================
+ Hits        12429    12445      +16     
- Misses       5199     5206       +7     
- Partials      305      306       +1     
Flag Coverage Δ
backend-unit 87.62% <75.00%> (-0.02%) ⬇️
frontend-unit 64.79% <42.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...client-web/src/common/components/PodCard/index.tsx 0.00% <0.00%> (ø)
apps/client-web/src/core/initializers/sentry.ts 0.00% <0.00%> (ø)
...lient-web/src/core/typePolicies/mashcardContext.ts 0.00% <0.00%> (ø)
...c/docs_legacy/common/components/PageMenu/index.tsx 0.00% <0.00%> (ø)
..._legacy/common/components/PathBreadcrumb/index.tsx 0.00% <0.00%> (ø)
.../docs_legacy/common/components/PodSelect/index.tsx 0.00% <ø> (ø)
...legacy/common/components/TopbarMore/index.style.ts 0.00% <ø> (ø)
...docs_legacy/common/components/TopbarMore/index.tsx 0.00% <0.00%> (ø)
...ocs_legacy/common/components/TrashPrompt/index.tsx 0.00% <0.00%> (ø)
..._legacy/common/components/TrashTable/TrashItem.tsx 0.00% <0.00%> (ø)
... and 570 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09b5ff9...1dae5e0. Read the comment docs.

@aligo aligo temporarily deployed to pr_preview July 20, 2022 03:19 Inactive
@github-actions
Copy link
Contributor

This pull request has been built and is available for preview at pr421.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

@stackia stackia temporarily deployed to pr_preview July 20, 2022 07:57 Inactive
@aligo aligo temporarily deployed to pr_preview July 20, 2022 09:49 Inactive
@aligo aligo changed the title feat(trash) feat(trash): quick solution for restoring subpage Jul 20, 2022
@aligo aligo changed the title feat(trash): quick solution for restoring subpage feat(trash): quick solution for restoring subpage #162 Jul 20, 2022
@aligo aligo merged commit 05fdba7 into main Jul 20, 2022
@aligo aligo deleted the trash branch July 20, 2022 13:00
@aligo aligo linked an issue Jul 21, 2022 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when restore subpage in trash, subpage can not restore to page tree
2 participants