Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

refactor(legacy-editor): refactor tiptap react renderer #429

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

Darmody
Copy link
Contributor

@Darmody Darmody commented Jul 20, 2022

fix annoy flushSync warning.

fork @tiptap/react into our code base, and prepare for creating our own react renderer. Currently, just fix the problem base on the tiptap react renderer.

resolve #378

@Darmody Darmody temporarily deployed to pr_preview July 20, 2022 12:06 Inactive
@github-actions
Copy link
Contributor

This pull request has been built and is available for preview at pr429.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #429 (5b91706) into main (9774034) will increase coverage by 0.01%.
The diff coverage is 77.00%.

@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
+ Coverage   69.30%   69.32%   +0.01%     
==========================================
  Files        1057     1064       +7     
  Lines       17949    18113     +164     
  Branches     2474     2503      +29     
==========================================
+ Hits        12439    12556     +117     
- Misses       5204     5244      +40     
- Partials      306      313       +7     
Flag Coverage Δ
frontend-unit 64.87% <77.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ockViews/BlockContainer/useDisableActionOptions.ts 83.33% <ø> (ø)
...rc/components/blockViews/FormulaView/useFormula.ts 35.05% <ø> (ø)
...ackages/legacy-editor/src/context/EditorContext.ts 100.00% <ø> (ø)
...ages/legacy-editor/src/extensions/common/common.ts 80.00% <ø> (ø)
packages/legacy-editor/src/test/editor.ts 95.83% <ø> (ø)
...ditor/src/tiptapRefactor/ReactNodeViewRenderer.tsx 58.06% <58.06%> (ø)
...legacy-editor/src/tiptapRefactor/ReactRenderer.tsx 65.38% <65.38%> (ø)
...legacy-editor/src/tiptapRefactor/EditorContent.tsx 76.31% <76.31%> (ø)
...gacy-editor/src/tiptapRefactor/NodeViewContent.tsx 80.00% <80.00%> (ø)
...ages/legacy-editor/src/tiptapRefactor/useEditor.ts 95.00% <95.00%> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9774034...5b91706. Read the comment docs.

@Darmody Darmody merged commit 9810de3 into main Jul 20, 2022
@Darmody Darmody deleted the fix-tiptap-react-renderer branch July 20, 2022 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a new ReactRenderer for @tiptap ReactNodeView
2 participants