Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

refactor: remove currentPod for podMember and groupUpdateMember #431

Merged
merged 1 commit into from
Jul 20, 2022
Merged

refactor: remove currentPod for podMember and groupUpdateMember #431

merged 1 commit into from
Jul 20, 2022

Conversation

toadfanszz
Copy link
Contributor

@toadfanszz toadfanszz commented Jul 20, 2022 •
edited
Loading

refactor: podMember && groupUpdateMember
2ef79a9 
remove self.current_pod in specs

migrate: podMember

remove: groupUpdateMember
Signed-off-by: clszzyh <clszzyh@gmail.com>
@codecov
Copy link

codecov bot commented Jul 20, 2022 •
edited
Loading

Codecov Report

Merging #431 (2ef79a9) into main (9810de3) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
- Coverage   69.32%   69.30%   -0.02%     
==========================================
  Files        1064     1063       -1     
  Lines       18121    18100      -21     
  Branches     2505     2505              
==========================================
- Hits        12562    12544      -18     
+ Misses       5246     5244       -2     
+ Partials      313      312       -1
Flag Coverage Δ
backend-unit 87.55% <100.00%> (-0.08%) ⬇️
frontend-unit 64.88% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/client-web/src/common/graphql.ts 0.00% <ø> (ø)
apps/client-web/src/docs_legacy/common/graphql.ts 0.00% <ø> (ø)
...pages/hooks/useEditorOptions/useMentionCommands.ts 0.00% <0.00%> (ø)
...c/routes/$domain/settings/team/_shared/Members.tsx 0.00% <0.00%> (ø)
...server-monolith/app/graphql/types/mutation_type.rb 100.00% <ø> (ø)
...monolith/app/graphql/concerns/authenticate_user.rb 100.00% <100.00%> (ø)
...rver-monolith/app/graphql/resolvers/pod_members.rb 100.00% <100.00%> (ø)
packages/formula/src/grammar/completer.ts 94.69% <0.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9810de3...2ef79a9. Read the comment docs.

@toadfanszz toadfanszz mentioned this pull request Jul 20, 2022
Closed
10 tasks
@toadfanszz toadfanszz marked this pull request as ready for review July 20, 2022 13:54
@toadfanszz toadfanszz enabled auto-merge (squash) July 20, 2022 13:55
@github-actions
Copy link
Contributor

This pull request has been built and is available for preview at pr431.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

@toadfanszz toadfanszz merged commit dc594a5 into main Jul 20, 2022
@toadfanszz toadfanszz deleted the fix-active-storage branch July 20, 2022 14:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stackia stackia stackia approved these changes

@aligo aligo Awaiting requested review from aligo

@melchior-voidwolf melchior-voidwolf Awaiting requested review from melchior-voidwolf

@Darmody Darmody Awaiting requested review from Darmody

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toadfanszz @stackia