Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

fix(formula): spreadsheet rerender parse error #452

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

toadfanszz
Copy link
Contributor

@toadfanszz toadfanszz commented Jul 21, 2022

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #452 (251072c) into main (8a01c97) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #452      +/-   ##
==========================================
- Coverage   69.66%   69.66%   -0.01%     
==========================================
  Files        1060     1060              
  Lines       18027    18027              
  Branches     2496     2496              
==========================================
- Hits        12559    12558       -1     
- Misses       5155     5156       +1     
  Partials      313      313              
Flag Coverage Δ
frontend-unit 65.30% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/blockViews/Spreadsheet/SpreadsheetBlockView.tsx 31.57% <ø> (ø)
...ponents/blockViews/Spreadsheet/SpreadsheetCell.tsx 10.38% <0.00%> (-0.14%) ⬇️
...ts/blockViews/Spreadsheet/useFormulaSpreadsheet.ts 80.00% <ø> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a01c97...251072c. Read the comment docs.

@toadfanszz toadfanszz temporarily deployed to pr_preview July 21, 2022 13:43 Inactive
@github-actions
Copy link
Contributor

This pull request has been built and is available for preview at pr452.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

Signed-off-by: clszzyh <clszzyh@gmail.com>
@toadfanszz toadfanszz force-pushed the fix-formula-spreadsheet-rerender-bug branch from 3aeb650 to 251072c Compare July 21, 2022 14:43
@toadfanszz toadfanszz changed the title 1. reproduce bug fix(formula): spreadsheet rerender parse error Jul 21, 2022
@toadfanszz toadfanszz marked this pull request as ready for review July 21, 2022 14:45
@toadfanszz toadfanszz requested a review from Darmody as a code owner July 21, 2022 14:45
@aligo aligo merged commit 4173f7c into main Jul 22, 2022
@aligo aligo deleted the fix-formula-spreadsheet-rerender-bug branch July 22, 2022 01:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formula cell parse error when first load
2 participants