Arduino API extension: Stream::to() #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lient::read(buffer) returns an int This is related to esp8266/Arduino@cdd72f9
dok-net
added a commit
to dok-net/espsoftwareserial
that referenced
this pull request
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An Arduino API extension in progress imports
Client::read(buffer)definition toStream::read(buffer).This method returns an int.
Other classes inheriting from
Stream::which implement the same (non-virtual) function return asize_t(HardwareSerial, SoftwareSerial, FS). The function now exists, is virtual, and is an attempt to make the API coherent and able to implementStream::to*()functions. With more helpers in SoftwareSerial, buffers could be transferred using less copies / less intermediate buffers and less code.These helpers could be added in SoftwareSerial too in a separate PR.
This is related to esp8266/Arduino#6979 and specifically esp8266/Arduino@cdd72f9