Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor fix in autoencoding #3

Merged
merged 1 commit into from
Dec 4, 2021
Merged

fix: minor fix in autoencoding #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion autoencoding/autoencoding.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,12 @@ func (i *item) GetID() string {

func (i *item) SetID(id string) {
v := reflect.ValueOf(i.val).Elem()
v.FieldByName(i.id).SetString(id)
// Ideally there should be some tag field to specify if we should use this
// setter or not. For now, we will check if ID was set already, we will use
// that, else set
if v.FieldByName(i.id).String() == "" {
v.FieldByName(i.id).SetString(id)
}
}

func (i *item) Get() interface{} {
Expand Down