GCR Nested Paths

[bnutt]

Unlike quay.io, docker hub, GCR registries support nested paths nested paths in image names. This change will let sinker generate nested paths for images in GCR repositories.

[jpreese]

Thanks for the PR @bnutt! Admittedly I did take an educated guess with this. I read through https://cloud.google.com/container-registry/docs/pushing-and-pulling and looking at the naming restrictions of PROJECT-ID it didn't look possible.

I'm not seeing any naming restrictions for the name of the image, so slashes must be allowed in that piece of the URL then?

[bnutt]

Thanks for the PR @bnutt! Admittedly I did take an educated guess with this. I read through https://cloud.google.com/container-registry/docs/pushing-and-pulling and looking at the naming restrictions of PROJECT-ID it didn't look possible.

I'm not seeing any naming restrictions for the name of the image, so slashes must be allowed in that piece of the URL then?

That's correct @jpreese 😄 , as the docs suggest, the image is in the format of

docker tag [SOURCE_IMAGE] [HOSTNAME]/[PROJECT-ID]/[IMAGE]

IMAGE can contain slashes in it.

[jpreese]

Excellent, makes sense to me! Thanks again! I'll cut a new release.

[jpreese]

@bnutt https://github.com/plexsystems/sinker/releases/tag/v0.13.0

[luomoxu]

could add an option to set registries use nested paths or not,use a list to mark is not a complete solution

[jpreese]

could add an option to set registries use nested paths or not,use a list to mark is not a complete solution

I dont have any objections to adding some mechanism for users to choose nested or not, if the target supports it.