Skip to content
This repository has been archived by the owner on Jul 2, 2022. It is now read-only.

Make cljc code reloadable. #206

Merged
merged 1 commit into from
Aug 1, 2017
Merged

Conversation

featheredtoast
Copy link
Collaborator

Add dev-target js compiling folder to disallow cljs name conflicts during a
reload. dev-target feels like the best name to mirror 'target', but I am open to discussion here.

Re-enable wrap-reload in the dev environment, allowing routes to reload automatically on change, without a system restart.

This is in an effort to address some of the issues brought up on the mailing list.

@featheredtoast
Copy link
Collaborator Author

Changing where the app builds would also partially resolve #177 - the app build would be moved, and the min build would stay put.

@plexus
Copy link
Owner

plexus commented Jul 16, 2017

This way you lose the ability to inject dependencies into the routes, which is the whole reason we're using the system endpoint/routes components.

@featheredtoast
Copy link
Collaborator Author

What if we were to leave out the wrap-reload + routes config, as a separate issue, and focus only on the path restructure for right now? I bundled it as it all was relevant to "fix the reload experience" but we can itemize it further.

The main part from this is the classpath changes, because cljs compiling of cljc files to a location within the classpath breaks reloading.

@featheredtoast featheredtoast force-pushed the reload-fixes branch 2 times, most recently from 785bab9 to 9f6450b Compare August 1, 2017 03:54
@featheredtoast featheredtoast changed the title Make cljc code reloadable. add wrap-reload. Make cljc code reloadable. Aug 1, 2017
@featheredtoast
Copy link
Collaborator Author

Alright, cut out wrap-reload for another time.

The main focus of this is now to only add a directory named dev-target to compile into, and serve the compiled cljs out of that is outside the classpath when running from the repl.

add dev-target js compiling folder to disallow cljs name conflicts during a
reload.
@plexus
Copy link
Owner

plexus commented Aug 1, 2017

Thanks a lot Jeff!

@plexus plexus merged commit a515d76 into plexus:master Aug 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants