Skip to content
This repository has been archived by the owner on Jul 2, 2022. It is now read-only.

Project won't start with Java 9 #227

Closed
wants to merge 1 commit into from
Closed

Conversation

Risord
Copy link

@Risord Risord commented Dec 14, 2017

Applied workaround for figwheel Java 9 incompatibility issue described here: bhauman/lein-figwheel#612

Disclaimer: I have currently zero experience about Clojure(Script) ecosystem -> this works for me but I have no idea is it acceptable way.

Workaround for figwheel Java 9 incompatibility issue described here: bhauman/lein-figwheel#612
@featheredtoast
Copy link
Collaborator

Hey, thanks for reporting - looks like this will be fixed in upstream tooling. Once we adopt that as our base cljs version, we should be good.

I'll keep this issue open in the meantime for tracking.

@plexus
Copy link
Owner

plexus commented May 6, 2018

Chestnut 0.16.0 is out now, containing the latest stable ClojureScript. Does that mean this is fixed?

@beders
Copy link

beders commented Jul 19, 2018

Still happening with 0.16.0.
Merging this would fix the problem.

@plexus
Copy link
Owner

plexus commented Jul 20, 2018

If I read the upstream report correctly then this patch would break support for Java 8, which we also don't want to do.

@beders
Copy link

beders commented Jul 20, 2018

It looks like lein 2.8.1 also has issues (I'm getting a NullPointerException hawk.core/extract-paths-by-type/fn--26609 (core.clj:15) when running with Java 9 and lein 2.8.1)

How about adding a conditional section to project.clj and something like that?
(def is-at-least-java9 (>= (read-string (System/getProperty "java.vm.specification.version")) 9))

That would at least generate a project.clj that works out of the box for the current Java version used.

@featheredtoast
Copy link
Collaborator

I've got a workaround for this in #241 - Java 11 does not work with this solution, and needed the explicit extra dependency for this.

We can drop the dependency entirely with http-kit 2.3 and a newer version of clojurescript, but it'll take a little extra fiddling to get that part working OK.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants