Skip to content
This repository has been archived by the owner on Jul 2, 2022. It is now read-only.

Compatibility fixes: --reagent and lein figwheel #248

Closed
wants to merge 1 commit into from

Conversation

plexus
Copy link
Owner

@plexus plexus commented Aug 30, 2019

There's a bunch of existing documentation out there that starts with a lein new chestnut, and so we should try not to break existing invocations and uses. Even
though --reagent is now the default, it should still be possible to specify
the flag.

We should also make sure that lein figwheel continues to work. Normally we
start figwheel as part of the system, but sometimes people use Chestnut only for
the figwheel/clojurescript part, and in that case they might only care about
running Figwheel. Since we write our compiled js to dev-target/public, we should
make sure dev-target is on the classpath so the Figwheel web server can find it.

There's a bunch of existing documentation out there that starts with a `lein new
chestnut`, and so we should try not to break existing invocations and uses. Even
though `--reagent` is now the default, it should still be possible to specify
the flag.

We should also make sure that `lein figwheel` continues to work. Normally we
start figwheel as part of the system, but sometimes people use Chestnut only for
the figwheel/clojurescript part, and in that case they might only care about
running Figwheel. Since we write our compiled js to dev-target/public, we should
make sure dev-target is on the classpath so the Figwheel web server can find it.
@plexus
Copy link
Owner Author

plexus commented Aug 30, 2019

@featheredtoast could you quickly go over this to see if it looks good to you? It seems there are some Lambda Island episodes which are based on Chestnut which no longer work, which is a bit embarrassing 😅

@featheredtoast
Copy link
Collaborator

hmm, there's an issue with dev-target in that we want that to be outside of the path, due to reloading issues with cljc. When cljs compiles, it copies over the raw cljc files as well (for sourcemapping) into the target -- which makes clj thinks it needs to reload, which leads to a broken repl experience...

We may need to look at another way for making lein figwheel work in this case.

@plexus
Copy link
Owner Author

plexus commented Sep 6, 2019

Ok, I'll split this up so at least --reagent works again

@plexus plexus closed this Sep 6, 2019
@plexus plexus deleted the compat-fixes branch September 6, 2019 10:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants