brige: fix refreshing cloud access token

[jkralik]

Summary by CodeRabbit

• Refactor
  • Improved token refresh logic by introducing a configurable interval, enhancing device cloud communication reliability.
• Bug Fixes
  • Added a condition to check for an empty RefreshToken when receiving an Unauthorized response, ensuring proper handling of authentication errors.

[coderabbitai]

Walkthrough

The update introduces a more dynamic and efficient approach to managing token refresh intervals within a cloud bridge device management system. By defining a tickInterval constant, the system now has a standardized basis for operations, enhancing the precision of credential expiration checks. This change streamlines the token refresh process, ensuring timely updates and reducing the risk of service interruptions due to expired credentials.

Changes

File(s)	Summary
.../cloud/manager.go	Introduced tickInterval constant; updated isCredsExpiring for better token refresh logic.

🐰✨

In the land of code, where logic does abide,
A rabbit hopped, with changes to confide.
"Tick, tock," goes the clock, intervals align,
Ensuring tokens fresh, in every line.
With every hop, improvements we see,
A better, stronger bridge, for you and me.
🌈🖥️

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 0563a7a and 2facd0c.

Files selected for processing (1)

• bridge/device/cloud/manager.go (3 hunks)

Additional comments: 2

bridge/device/cloud/manager.go (2)

• 52-52: The introduction of the tickInterval constant is a good practice for maintainability and readability. It allows for easy adjustments and ensures consistency across the codebase.
• 357-366: The modifications in the isCredsExpiring method to adjust the token refresh logic based on the tickInterval are sound, ensuring that the token is refreshed with enough buffer time. Consider adding a comment explaining the logic behind refreshing the token when the remaining time is less than twice the tickInterval or one-third before expiration for clarity.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 76.81%. Comparing base (0563a7a) to head (2facd0c).

Files	Patch %	Lines
bridge/device/cloud/manager.go	83.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #452      +/-   ##
==========================================
- Coverage   76.83%   76.81%   -0.02%     
==========================================
  Files         115      115              
  Lines        6699     6702       +3     
==========================================
+ Hits         5147     5148       +1     
- Misses       1014     1015       +1     
- Partials      538      539       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 0563a7a and 532b77e.

Files selected for processing (2)

• bridge/device/cloud/manager.go (3 hunks)
• bridge/device/cloud/signIn.go (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• bridge/device/cloud/manager.go

Additional comments: 1

bridge/device/cloud/signIn.go (1)

• 74-74: The addition of the condition to check for an empty RefreshToken upon receiving an Unauthorized response code is a good security practice. It ensures that the device attempts to sign in only when it has valid credentials, preventing unnecessary or unauthorized access attempts.

However, consider adding a comment explaining the rationale behind this condition for future maintainability.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud