Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UDP Server Option Duplication in ListenAndServeWithOptions #527

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

sdeboeck
Copy link
Contributor

This change ensures that when a UDP option is provided in the options list, it is appropriately added to both the TCP and UDP option slices, ensuring consistent behavior for both server types.

#526

@jkralik jkralik self-requested a review January 24, 2024 12:21
Copy link
Member

@jkralik jkralik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for your contribution. 👍

@jkralik jkralik merged commit 2e95ead into plgd-dev:master Jan 24, 2024
11 checks passed
@sdeboeck sdeboeck deleted the fix-udp-server-option branch January 24, 2024 14:40
@Danielius1922 Danielius1922 linked an issue Feb 15, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListenAndServeWithOptions doesn't correctly start UDP server
2 participants